From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ayaz Abdulla <aabdulla@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH] forcedeth: make msi-x different name for rx-tx
Date: Fri, 6 Feb 2009 18:15:44 +0100 [thread overview]
Message-ID: <20090206171544.GA16190@elte.hu> (raw)
In-Reply-To: <498C6C15.3050807@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Ingo Molnar wrote:
> > Cool cleanups!
> >
> > Would you mind to also fix the following - on all my systems that have
> > forcedeth gigabit ethernet i've been getting these bogus warnings for
> > _years_, under moderate load:
> >
> > eth2: too many iterations (16) in nv_nic_irq.
> >
> > I think a 64 iterations limit will work much better. (i tried a limit of 50
> > a year ago for a while and it worked fine and had no side effects - and the
> > bogus warnings were done.)
>
> you may enable CONFIG_FORCEDETH_NAPI.
>
> we should enable NAPI for forcedeth by default, and try to squash more bugs out.
i do have that:
CONFIG_FORCEDETH=y
CONFIG_FORCEDETH_NAPI=y
and the messages still come.
Ingo
next prev parent reply other threads:[~2009-02-06 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 4:59 [PATCH] forcedeth: make msi-x different name for rx-tx Yinghai Lu
2009-02-06 5:00 ` [PATCH] forcedeth: don't clear nic_poll_irq too early Yinghai Lu
2009-02-06 9:31 ` David Miller
2009-02-06 5:01 ` [PATCH] forcedeth: disable irq at first before schedule rx Yinghai Lu
2009-02-06 9:32 ` David Miller
2009-02-06 5:01 ` [PATCH] forcedeth: ck804 and mcp55 doesn't need timerirq Yinghai Lu
2009-02-06 9:32 ` David Miller
2009-02-06 5:02 ` [PATCH] forcedeth: enable msix to default Yinghai Lu
2009-02-06 9:32 ` David Miller
2009-02-06 9:31 ` [PATCH] forcedeth: make msi-x different name for rx-tx David Miller
2009-02-06 14:49 ` Ingo Molnar
2009-02-06 16:57 ` Yinghai Lu
2009-02-06 17:15 ` Ingo Molnar [this message]
2009-02-06 17:54 ` Yinghai Lu
2009-02-09 12:00 ` Ingo Molnar
2009-02-09 19:13 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206171544.GA16190@elte.hu \
--to=mingo@elte.hu \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).