From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [urcu PATCH] test_urcu.c: use gettid()
Date: Sat, 7 Feb 2009 19:17:13 -0500 [thread overview]
Message-ID: <20090208001713.GA5282@Krystal> (raw)
In-Reply-To: <1233946197-32046-1-git-send-email-bert.wesarg@googlemail.com>
* Bert Wesarg (bert.wesarg@googlemail.com) wrote:
> It's probably better to print the tid for each thread, not the pid.
>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>
Merged, thanks !
Mathieu
> ---
> test_urcu.c | 28 ++++++++++++++++++++++++----
> 1 files changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/test_urcu.c b/test_urcu.c
> index db0b68c..ea5a784 100644
> --- a/test_urcu.c
> +++ b/test_urcu.c
> @@ -17,6 +17,23 @@
> #include <unistd.h>
> #include <stdio.h>
> #include <assert.h>
> +#include <sys/syscall.h>
> +
> +#if defined(_syscall0)
> +_syscall0(pid_t, gettid)
> +#elif defined(__NR_gettid)
> +static inline pid_t gettid(void)
> +{
> + return syscall(__NR_gettid);
> +}
> +#else
> +#warning "use pid as tid"
> +static inline pid_t gettid(void)
> +{
> + return getpid();
> +}
> +#endif
> +
> #include "urcu.h"
>
> struct test_array {
> @@ -36,8 +53,8 @@ void *thr_reader(void *arg)
> int qparity, i, j;
> struct test_array *local_ptr;
>
> - printf("thread %s, thread id : %lu, pid %lu\n",
> - "reader", pthread_self(), (unsigned long)getpid());
> + printf("thread %s, thread id : %lx, tid %lu\n",
> + "reader", pthread_self(), (unsigned long)gettid());
> sleep(2);
>
> urcu_register_thread();
> @@ -66,8 +83,8 @@ void *thr_writer(void *arg)
> int i;
> struct test_array *new, *old;
>
> - printf("thread %s, thread id : %lu, pid %lu\n",
> - "writer", pthread_self(), (unsigned long)getpid());
> + printf("thread %s, thread id : %lx, tid %lu\n",
> + "writer", pthread_self(), (unsigned long)gettid());
> sleep(2);
>
> for (i = 0; i < 10000000; i++) {
> @@ -104,6 +121,9 @@ int main()
> void *tret;
> int i;
>
> + printf("thread %-6s, thread id : %lx, tid %lu\n",
> + "main", pthread_self(), (unsigned long)gettid());
> +
> for (i = 0; i < NR_READ; i++) {
> err = pthread_create(&tid_reader[i], NULL, thr_reader, NULL);
> if (err != 0)
> --
> tg: (24316d1..) bw/use-gettid (depends on: master)
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2009-02-08 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 18:49 [urcu PATCH] test_urcu.c: use gettid() Bert Wesarg
2009-02-08 0:17 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090208001713.GA5282@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=bert.wesarg@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).