From: Pierre Ossman <drzeus@drzeus.cx>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Kumar Gala <galak@kernel.crashing.org>,
Liu Dave <DaveLiu@freescale.com>,
sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 10/11] sdhci: Add quirk for Freescale eSDHC controllers
Date: Sun, 8 Feb 2009 22:12:09 +0100 [thread overview]
Message-ID: <20090208221209.628ae782@mjolnir.drzeus.cx> (raw)
In-Reply-To: <20090206180701.GJ11548@oksana.dev.rtsoft.ru>
[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]
On Fri, 6 Feb 2009 21:07:01 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> This patch adds SDHCI_QUIRK_FSL quirk. The quirk is used to instruct
> the sdhci driver about various FSL eSDHC host incompatibilities:
>
No device quirks please. They should be for specific bugs, not lumping
things together like this. Otherwise we'll soon have an unmanageable
mess.
> 1) FSL eSDHC controllers can support maximum block size up to 4096
> bytes. The MBL (Maximum Block Length) field in the capabilities
> register extended by one bit.
>
> (Should we implement a dedicated quirk for this? I.e.
> SDHCI_QUIRK_MAX_BLK_SZ_4096?)
>
Yes please. It would have to mean "always support 4096" though, not
"turn reserved bit 18 into a block length bit".
> 2) sdhci_init() is needed after error conditions.
>
> (Can we safely do this for all controllers?)
>
Please investigate which part of sdhci_init() is needed. How does it
break without this?
> 3) Small udelay is needed to make eSDHC work in PIO mode. Without
> the delay reading causes endless interrupt storm, and writing
> corrupts data. The first guess would be that we must wait for
> some bit in some register, but I didn't find any reliable bits
> that changes before and after the delay. Though, more investigation
> on this is in my todo list.
Please try to investigate more, but if you cannot improve it further
then a specific quirk can be added.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-08 21:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 18:05 [PATCH RFC 0/11] FSL eSDHC support: second call for comments Anton Vorontsov
2009-02-06 18:06 ` [PATCH 01/11] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-06 18:06 ` [PATCH 02/11] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-02-08 20:50 ` Pierre Ossman
2009-02-13 14:40 ` Anton Vorontsov
2009-02-21 15:57 ` Pierre Ossman
2009-03-04 17:46 ` Anton Vorontsov
2009-03-08 14:08 ` Pierre Ossman
2009-02-06 18:06 ` [PATCH 03/11] sdhci: Add type checking for " Anton Vorontsov
2009-02-08 20:53 ` Pierre Ossman
2009-02-06 18:06 ` [PATCH 04/11] sdhci: Add support for card-detection polling Anton Vorontsov
2009-02-08 20:57 ` Pierre Ossman
2009-02-06 18:06 ` [PATCH 05/11] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-02-06 18:06 ` [PATCH 06/11] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-02-06 18:06 ` [PATCH 07/11] sdhci: Add quirk to suppress PIO interrupts during DMA transfers Anton Vorontsov
2009-02-08 21:02 ` Pierre Ossman
2009-02-06 18:06 ` [PATCH 08/11] sdhci: Add support for hosts that don't specify clocks in the cap. register Anton Vorontsov
2009-02-08 21:04 ` Pierre Ossman
2009-02-06 18:06 ` [PATCH 09/11] sdhci: Add set_clock callback Anton Vorontsov
2009-02-08 21:06 ` Pierre Ossman
2009-02-06 18:07 ` [PATCH 10/11] sdhci: Add quirk for Freescale eSDHC controllers Anton Vorontsov
2009-02-08 21:12 ` Pierre Ossman [this message]
2009-02-13 14:42 ` Anton Vorontsov
2009-02-06 18:07 ` [PATCH 11/11] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-02-08 20:33 ` [PATCH RFC 0/11] FSL eSDHC support: second call for comments Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090208221209.628ae782@mjolnir.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=DaveLiu@freescale.com \
--cc=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=ben-linux@fluff.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).