From: Wolfram Sang <w.sang@pengutronix.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Frank Seidel <frank@f-seidel.de>, Frank Seidel <fseidel@suse.de>,
linux kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, ben-linux@fluff.org,
linux-i2c@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
ukleinek@informatik.uni-freiburg.de,
Frans Pop <elendil@planet.nl>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks
Date: Mon, 9 Feb 2009 09:35:37 +0100 [thread overview]
Message-ID: <20090209083537.GA3438@pengutronix.de> (raw)
In-Reply-To: <20090208144751.46184041@hyperion.delvare>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
> I mean the (first) printk in the loop, not the last printk in this
> function. So what I am suggesting is:
>
> + printk(KERN_DEBUG);
> for (i = 0; i < i2c->irqlogidx; i++)
> printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> printk("\n");
Hmm, I was told (by Jean ;)) that every printk should end with newline,
otherwise it might get interrupted with other output -> mess.
Bye,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-09 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 13:45 [PATCH] i2c: add missing KERN_* constants to printks Frank Seidel
2009-02-06 18:35 ` Uwe Kleine-König
2009-02-06 19:59 ` Frank Seidel
2009-02-06 20:53 ` Uwe Kleine-König
2009-02-06 21:23 ` Jean Delvare
2009-02-07 10:37 ` Frank Seidel
2009-02-07 10:52 ` Uwe Kleine-König
2009-02-07 15:58 ` Jean Delvare
2009-02-07 23:05 ` Jean Delvare
2009-02-08 13:11 ` Frank Seidel
2009-02-08 13:47 ` Jean Delvare
2009-02-08 14:16 ` Frank Seidel
2009-02-09 8:35 ` Wolfram Sang [this message]
2009-02-09 10:27 ` Jean Delvare
2009-02-08 14:18 ` [PATCHv2 1/2] " Frank Seidel
2009-02-08 14:20 ` [PATCHv2 2/2] i2c: adapt debug macros for KERN_* constants Frank Seidel
2009-02-09 15:16 ` Jean Delvare
2009-02-10 15:16 ` Wolfram Sang
2009-02-21 12:39 ` Wolfram Sang
2009-02-09 12:22 ` [PATCHv2 1/2] i2c: add missing KERN_* constants to printks Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209083537.GA3438@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).