From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH E 12/14] OMAP clock: unnecessary clock flag removal fiesta
Date: Mon, 23 Feb 2009 15:50:49 +0000 [thread overview]
Message-ID: <20090223155049.GA27688@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090128192759.29333.76642.stgit@localhost.localdomain>
On Wed, Jan 28, 2009 at 12:28:01PM -0700, Paul Walmsley wrote:
> 4. The CONFIG_PARTICIPANT flags indicates to the clock rate and parent
> changing functions that they should not be used on this clock. Better
> just to remove the clock function pointers that operate on those
> clocks. The name of the flag is just terrible: its meaning has almost
> nothing to do with its name, and the use of the CONFIG_ prefix makes
> it appear to be a Kconfig option. Get rid of it.
Hmm. Completely agree over the naming issue, however I think this
opens a hole.
> @@ -780,12 +772,6 @@ int omap2_clk_set_rate(struct clk *clk, unsigned long rate)
>
> pr_debug("clock: set_rate for clock %s to rate %ld\n", clk->name, rate);
>
> - /* CONFIG_PARTICIPANT clocks are changed only in sets via the
> - rate table mechanism, driven by mpu_speed */
> - if (clk->flags & CONFIG_PARTICIPANT)
> - return -EINVAL;
> -
> - /* dpll_ck, core_ck, virt_prcm_set; plus all clksel clocks */
> if (clk->set_rate)
> ret = clk->set_rate(clk, rate);
>
The removal of this can be mitigated as indicated; not having a set_rate
method does indeed cause this to return -EINVAL.
> @@ -830,9 +816,6 @@ int omap2_clk_set_parent(struct clk *clk, struct clk *new_parent)
> {
> u32 field_val, v, parent_div;
>
> - if (clk->flags & CONFIG_PARTICIPANT)
> - return -EINVAL;
> -
> if (!clk->clksel)
> return -EINVAL;
>
This one, however, is not...
> @@ -1020,16 +1018,13 @@ static struct clk mpu_ck = { /* Control cpu */
> .parent = &core_ck,
> .prcm_mod = MPU_MOD,
> .flags = CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X |
> - ALWAYS_ENABLED | DELAYED_APP |
> - CONFIG_PARTICIPANT | RATE_PROPAGATES,
> + ALWAYS_ENABLED | DELAYED_APP,
> .clkdm = { .name = "mpu_clkdm" },
> .init = &omap2_init_clksel_parent,
> .clksel_reg = CM_CLKSEL,
> .clksel_mask = OMAP24XX_CLKSEL_MPU_MASK,
> .clksel = mpu_clksel,
> .recalc = &omap2_clksel_recalc,
> - .round_rate = &omap2_clksel_round_rate,
> - .set_rate = &omap2_clksel_set_rate
> };
>
> /*
For example, here we have a clock which was previously marked with
CONFIG_PARTICIPANT, and has a non-NULL clksel member. This means
that clk_set_parent() would return -EINVAL before, but would have
an effect after the removal of this flag.
The same is true of dsp_fck, dsp_irate_ick, iva1_ifck, core_l3_ck,
usb_l4_ick and mdm_ick.
So, is this change safe for these clocks?
(Note: all the other flags have already gone in my tree.)
next prev parent reply other threads:[~2009-02-23 15:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 19:27 [PATCH E 00/14] OMAP clock, E of F: SDRAM fixes, clock optimization Paul Walmsley
2009-01-28 19:27 ` [PATCH E 01/14] OMAP2 SDRC: move mach-omap2/memory.h into include/asm-arm/arch-omap/sdrc.h Paul Walmsley
2009-01-28 19:27 ` [PATCH E 02/14] OMAP2 SDRC: rename memory.c to sdrc2xxx.c Paul Walmsley
2009-01-28 19:27 ` [PATCH E 03/14] OMAP2 SDRC: separate common OMAP2/3 code from OMAP2xxx code Paul Walmsley
2009-01-28 19:27 ` [PATCH E 04/14] OMAP2 SDRC: add SDRAM timing parameter infrastructure Paul Walmsley
2009-01-28 19:27 ` [PATCH E 05/14] OMAP3 clock: add omap3_core_dpll_m2_set_rate() Paul Walmsley
2009-01-28 19:27 ` [PATCH E 06/14] PM: OMAP3: Make sure clk_disable_unused() order is correct Paul Walmsley
2009-01-28 19:27 ` [PATCH E 07/14] OMAP2/3 clock: use standard set_rate fn in omap2_clk_arch_init() Paul Walmsley
2009-01-28 19:27 ` [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c Paul Walmsley
2009-01-29 17:41 ` Russell King - ARM Linux
2009-01-30 8:42 ` Paul Walmsley
2009-01-30 8:52 ` Russell King - ARM Linux
2009-01-30 14:23 ` Woodruff, Richard
2009-01-31 11:40 ` Russell King - ARM Linux
2009-02-03 8:42 ` Paul Walmsley
2009-02-03 9:45 ` Paul Walmsley
2009-02-02 7:13 ` Paul Walmsley
2009-02-03 13:18 ` Russell King - ARM Linux
2009-01-28 19:27 ` [PATCH E 09/14] OMAP2/3 clock: drop recalc function pointers from fixed rate clocks Paul Walmsley
2009-01-28 19:27 ` [PATCH E 10/14] OMAP clock: support "dry run" rate and parent changes Paul Walmsley
2009-02-08 13:17 ` Russell King - ARM Linux
2009-02-08 19:48 ` David Brownell
2009-02-11 7:53 ` Paul Walmsley
2009-02-08 15:53 ` Russell King - ARM Linux
2009-02-11 8:18 ` Paul Walmsley
2009-01-28 19:27 ` [PATCH E 11/14] OMAP clock: track child clocks Paul Walmsley
2009-01-29 15:14 ` Russell King - ARM Linux
2009-01-29 22:06 ` Russell King - ARM Linux
2009-01-30 8:35 ` Paul Walmsley
2009-02-02 4:57 ` Paul Walmsley
2009-02-09 14:11 ` Russell King - ARM Linux
2009-02-13 7:01 ` Paul Walmsley
2009-02-14 11:23 ` Russell King - ARM Linux
2009-02-14 11:36 ` Russell King - ARM Linux
2009-02-25 9:45 ` Paul Walmsley
2009-02-19 12:19 ` Russell King - ARM Linux
2009-02-20 0:50 ` Woodruff, Richard
2009-02-23 16:03 ` Russell King - ARM Linux
2009-02-24 12:35 ` Woodruff, Richard
2009-03-02 23:02 ` Paul Walmsley
2009-03-03 16:45 ` Russell King - ARM Linux
2009-02-22 23:37 ` Paul Walmsley
2009-02-24 9:43 ` Russell King - ARM Linux
2009-01-29 19:52 ` Russell King - ARM Linux
2009-02-02 7:57 ` Paul Walmsley
2009-01-28 19:28 ` [PATCH E 12/14] OMAP clock: unnecessary clock flag removal fiesta Paul Walmsley
2009-02-23 15:50 ` Russell King - ARM Linux [this message]
2009-03-02 22:35 ` Paul Walmsley
2009-01-28 19:28 ` [PATCH E 13/14] OMAP2/3 clock: remove clk->owner Paul Walmsley
2009-01-28 19:28 ` [PATCH E 14/14] OMAP clock: rearrange clock.h structure order Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090223155049.GA27688@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).