From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: linux-mm@kvack.org, Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Bharata B Rao <bharata@in.ibm.com>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] Memory controller soft limit patches (v3)
Date: Mon, 2 Mar 2009 15:18:30 +0900 [thread overview]
Message-ID: <20090302151830.3770e528.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20090302060519.GG11421@balbir.in.ibm.com>
On Mon, 2 Mar 2009 11:35:19 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > Then, not-sorted RB-tree can be there.
> >
> > BTW,
> > time_after(jiffies, 0)
> > is buggy (see definition). If you want make this true always,
> > time_after(jiffies, jiffies +1)
> >
>
> HZ/4 is 250/4 jiffies in the worst case (62). We have
> time_after(jiffies, next_update_interval) and next_update_interval is
> set to last_tree_update + 62. Not sure if I got what you are pointing
> to.
>
+ unsigned long next_update = 0;
+ unsigned long flags;
+
+ if (!css_tryget(&mem->css))
+ return;
+ prev_usage_in_excess = mem->usage_in_excess;
+ new_usage_in_excess = res_counter_soft_limit_excess(&mem->res);
+
+ if (time_check)
+ next_update = mem->last_tree_update +
+ MEM_CGROUP_TREE_UPDATE_INTERVAL;
+ if (new_usage_in_excess && time_after(jiffies, next_update)) {
+ if (prev_usage_in_excess)
+ mem_cgroup_remove_exceeded(mem);
+ mem_cgroup_insert_exceeded(mem);
+ updated_tree = true;
+ } else if (prev_usage_in_excess && !new_usage_in_excess) {
+ mem_cgroup_remove_exceeded(mem);
+ updated_tree = true;
+ }
My point is what happens if time_check==false.
time_afrter(jiffies, 0) is buggy.
Thanks,
-Kame
next prev parent reply other threads:[~2009-03-02 6:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 6:29 [PATCH 0/4] Memory controller soft limit patches (v3) Balbir Singh
2009-03-01 6:30 ` [PATCH 1/4] Memory controller soft limit documentation (v3) Balbir Singh
2009-03-01 6:30 ` [PATCH 2/4] Memory controller soft limit interface (v3) Balbir Singh
2009-03-02 2:03 ` KAMEZAWA Hiroyuki
2009-03-02 4:46 ` Balbir Singh
2009-03-02 5:35 ` KAMEZAWA Hiroyuki
2009-03-02 6:07 ` Balbir Singh
2009-03-02 6:19 ` KAMEZAWA Hiroyuki
2009-03-02 6:29 ` Balbir Singh
2009-03-01 6:30 ` [PATCH 3/4] Memory controller soft limit organize cgroups (v3) Balbir Singh
2009-03-01 6:30 ` [PATCH 4/4] Memory controller soft limit reclaim on contention (v3) Balbir Singh
2009-03-02 3:08 ` KOSAKI Motohiro
2009-03-02 4:44 ` Balbir Singh
2009-03-03 2:43 ` KOSAKI Motohiro
2009-03-03 11:17 ` Balbir Singh
2009-03-04 0:07 ` KOSAKI Motohiro
2009-03-02 0:24 ` [PATCH 0/4] Memory controller soft limit patches (v3) KAMEZAWA Hiroyuki
2009-03-02 4:40 ` Balbir Singh
2009-03-02 5:32 ` KAMEZAWA Hiroyuki
2009-03-02 6:05 ` Balbir Singh
2009-03-02 6:18 ` KAMEZAWA Hiroyuki [this message]
2009-03-02 17:52 ` Balbir Singh
2009-03-03 0:03 ` KAMEZAWA Hiroyuki
2009-03-03 11:23 ` Balbir Singh
2009-03-02 6:21 ` KAMEZAWA Hiroyuki
2009-03-02 6:36 ` Balbir Singh
2009-03-02 7:06 ` KAMEZAWA Hiroyuki
2009-03-02 7:17 ` KAMEZAWA Hiroyuki
2009-03-02 12:42 ` Balbir Singh
2009-03-02 14:04 ` KAMEZAWA Hiroyuki
2009-03-02 17:41 ` Balbir Singh
2009-03-02 23:59 ` KAMEZAWA Hiroyuki
2009-03-03 11:12 ` Balbir Singh
2009-03-03 11:50 ` KAMEZAWA Hiroyuki
2009-03-03 13:14 ` Balbir Singh
2009-03-05 9:04 ` KAMEZAWA Hiroyuki
2009-03-05 9:13 ` KAMEZAWA Hiroyuki
2009-03-05 15:26 ` Balbir Singh
2009-03-05 23:53 ` KAMEZAWA Hiroyuki
2009-03-06 3:23 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302151830.3770e528.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=bharata@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).