From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Dan Smith <danms@us.ibm.com>,
containers@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] c/r: Add CR_COPY() macro (v3)
Date: Wed, 4 Mar 2009 09:05:19 -0600 [thread overview]
Message-ID: <20090304150519.GB10186@us.ibm.com> (raw)
In-Reply-To: <1236128437.22399.31.camel@nimitz>
Quoting Dave Hansen (dave@linux.vnet.ibm.com):
> On Tue, 2009-03-03 at 16:57 -0800, Dan Smith wrote:
> > DH> Did you convince Nathan that this ends up being a good idea?
> >
> > Technically he hasn't seen this version, but my hopes are not high
> > that he will change his mind. If the feedback is that they're not
> > liked, I'll happily remove them.
>
> I just figure if Nathan feels that strongly that we'll encounter more
> people who feel even more so. So, I was curious if he changed his mind
> somehow.
I maintain however that two strong advantages of moving the checkpoint
and restart of simple registers etc into a single function are:
1. we won't forget to add (or accidentally lose) one or the
other
2. any actual special handling at checkpoint or restart, like
the loading of access registers at restart on s390x,
stand out
-serge
next prev parent reply other threads:[~2009-03-04 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 15:56 [PATCH 0/3] c/r: Add s390 support Dan Smith
2009-03-03 15:56 ` [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs Dan Smith
2009-03-03 16:08 ` Dave Hansen
2009-03-04 0:56 ` Dan Smith
2009-03-04 0:59 ` Dave Hansen
2009-03-03 15:56 ` [PATCH 2/3] c/r: Add CR_COPY() macro (v3) Dan Smith
2009-03-03 16:22 ` Dave Hansen
2009-03-04 0:57 ` Dan Smith
2009-03-04 1:00 ` Dave Hansen
2009-03-04 15:05 ` Serge E. Hallyn [this message]
2009-03-18 7:51 ` Oren Laadan
2009-03-18 13:43 ` Serge E. Hallyn
2009-03-04 19:53 ` Nathan Lynch
2009-03-04 20:18 ` Dave Hansen
2009-03-04 20:01 ` Nathan Lynch
2009-03-04 20:18 ` Dan Smith
2009-03-03 15:56 ` [PATCH 3/3] c/r: define s390-specific checkpoint-restart code (v7) Dan Smith
2009-03-03 22:40 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304150519.GB10186@us.ibm.com \
--to=serue@us.ibm.com \
--cc=containers@lists.osdl.org \
--cc=danms@us.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).