Re: [PATCH 4/5] lis3: solve dependency between core and ACPI

From: Daniel Mack <daniel@caiaq.de>
To: "Éric Piel" <eric.piel@tremplin-utc.net>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 4/5] lis3: solve dependency between core and ACPI
Date: Mon, 16 Mar 2009 20:09:54 +0100	[thread overview]
Message-ID: <20090316190954.GK16052@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090304014350.GC5165@buzzloop.caiaq.de>

Hi,

On Wed, Mar 04, 2009 at 02:43:50AM +0100, Daniel Mack wrote:
> On Tue, Mar 03, 2009 at 08:54:50PM +0100, Éric Piel wrote:
> > Daniel Mack schreef:
> > > This solves the dependency between lis3lv02d.[ch] and ACPI specific
> > > methods. It introduces a ->bus_priv pointer to the device struct which
> > > is casted to 'struct acpi_device' in the ACIP layer. Changed hp_accel.c
> > > accordingly.
> > > 
> > > This also moves the read_8() and read_16() routines from hp_accel.c to
> > > lis3lv02d.c as they are not specific to ACPI.
> > Hello,
> > I've tried the patch series on my laptop. This particular patch burst
> > the driver... need some work :-) The values are not read correctly and
> > the IRQ is not detected. See down in the code...
> 
> Ok, obvious fixes. I'll post a new set of the three topmost patches -
> could you test them again, please?

Could anyone test that on hardware which has a lis3 chip? I'd like to
avoid missing the next merge window for this :)

Thanks,
Daniel