From: Dhaval Giani <dhaval@linux.vnet.ibm.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Bob Copeland <me@bobcopeland.com>,
Dhaval Giani <dhaval.lists@thegianis.in>,
linville@tuxdriver.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ath5k: fix hw rate index condition
Date: Mon, 30 Mar 2009 14:29:52 +0530 [thread overview]
Message-ID: <20090330085952.GB3837@linux.vnet.ibm.com> (raw)
In-Reply-To: <49A9C3D7.8060706@gmail.com>
On Sun, Mar 01, 2009 at 12:08:07AM +0100, Jiri Slaby wrote:
> On 15.2.2009 14:47, Bob Copeland wrote:
>> On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
>>> So I finally managed to hit this on 2.6.29-rc3. It is hard to
>>> reproduce, so I hope so much information is enough to give you a good
>>> guess. This time it hit while trying to connect to an open network at
>>> the airport.
>>
>>> WARNING: at net/mac80211/rx.c:2236 __ieee80211_rx+0x96/0x571 [mac80211]()
>>> Hardware name: 2007CS3
>>> RATE=255, BAND=8
>>
>> band is supposed to be sc->curband? 8 is way wrong.
>
> If you look into the patch which outputs this (backtrace in this
> thread), sband->n_bitrates is 8. I have no idea what I have been smoking
> the day I wrote it, but BAND= for sure isn't the right name for that
> thing. Sorry for the confusion.
>
>> rate could be 255
>> if, for some reason, the hardware rate wasn't in the rate table.
>
> So, we have a fix for this, right? I mean the u8->s8 sc->rate_idx
> conversion or alike...
Where is the fix? Is it merged in? I still see this happen on 2.6.29
thanks,
--
regards,
Dhaval
next prev parent reply other threads:[~2009-03-30 9:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 17:07 WARNING: at net/mac80211/rx.c:2234 __ieee80211_rx+0x7f/0x559 [mac80211]() Dhaval Giani
2009-01-07 13:51 ` [PATCH 1/1] ath5k: fix hw rate index condition Jiri Slaby
2009-01-07 14:36 ` Jiri Slaby
2009-01-07 15:22 ` Dhaval Giani
2009-01-07 15:30 ` Jiri Slaby
2009-02-02 7:57 ` Dhaval Giani
2009-02-15 13:47 ` Bob Copeland
2009-02-28 23:08 ` Jiri Slaby
2009-03-30 8:59 ` Dhaval Giani [this message]
2009-03-30 16:58 ` Bob Copeland
2009-03-30 17:59 ` Dhaval Giani
2009-03-30 18:13 ` Bob Copeland
2009-03-31 3:51 ` Dhaval Giani
2009-03-31 12:23 ` Bob Copeland
2009-04-08 15:22 ` [ath5k-devel] " Bob Copeland
2009-03-15 21:27 ` Stefan Lippers-Hollmann
2009-03-15 21:35 ` Michael Buesch
2009-03-23 0:45 ` Stefan Lippers-Hollmann
2009-03-23 2:31 ` Bob Copeland
2009-02-26 22:44 Jiri Slaby
2009-02-26 23:15 ` Bob Copeland
2009-02-26 23:19 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330085952.GB3837@linux.vnet.ibm.com \
--to=dhaval@linux.vnet.ibm.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=davem@davemloft.net \
--cc=dhaval.lists@thegianis.in \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).