linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: minyard@acm.org, linux-kernel@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 4/5] IPMI: Add console oops catcher
Date: Thu, 2 Apr 2009 14:14:45 -0700	[thread overview]
Message-ID: <20090402141445.3a7a6504.akpm@linux-foundation.org> (raw)
In-Reply-To: <49ADC559.7040705@ct.jp.nec.com>

On Tue, 03 Mar 2009 16:03:37 -0800
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> ...
> > This reader is unable to determine what the mystery preempt_disable()
> > is here for.  It needs a comment, please.
> 
> I cannot recall why it's here. So a comment is really needed.
> This preempt_disable() may not be needed.
> 
> > What happens if two CPUs oops at the same time (which is fairly common)?
> 
> ...
>
> OK. I'll look at this.
> 
> > It would be prudent to have a timeout in this loop.  The machine has
> > crashed and subsystems and hardware and memory are in an unknown and
> > possibly bad state.
> 
> Right.
>
> ...
> 
> > This looks like we're abusing the "unblank" method.
> > 
> > If you think that the console subsystem is missing some capability
> > which this driver needs then please do prefer to fix the console
> > subsystem, rather than awkwardly making things fit.
> 
> OK. Will take a look about this point.
> 

None of this happened.

It makes me reluctant to merge that patches as they stand, because then
it all gets forgotten about, whereas holding the patches back will
remind us that updates are needed.



  reply	other threads:[~2009-04-02 21:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 15:21 [PATCH 4/5] IPMI: Add console oops catcher Corey Minyard
2009-03-03 21:20 ` Andrew Morton
2009-03-04  0:03   ` Hiroshi Shimamoto
2009-04-02 21:14     ` Andrew Morton [this message]
2009-04-15  6:40       ` Hiroshi Shimamoto
2009-04-15 14:34         ` Corey Minyard
2009-04-15 15:07           ` [Openipmi-developer] " dann frazier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402141445.3a7a6504.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).