From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 2/2] irq: only update affinity in chip set_affinity()
Date: Wed, 8 Apr 2009 14:54:15 +0200 [thread overview]
Message-ID: <20090408125415.GJ18581@elte.hu> (raw)
In-Reply-To: <49D6900B.2020107@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Impact: keep affinity consistent
>
> irq_set_affinity() and move_masked_irq() try to assign affinity
> before calling chip set_affinity(). some archs are assigning again
> in set_affinity again.
>
> something like:
> cpumask_cpy(desc->affinity, mask);
> desc->chip->set_affinity(mask);
>
> in the failing path, affinity should not be touched.
>
> also set_extra_move_desc() ( called by set_affinity) will rely on
> the old affinity to decide if need to move irq_desc to different
> node when logical flat apic mode is used.
>
> So try remove those assignment, and make some missed arch to
> assign affinity in their set_affinity.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> --
> arch/alpha/kernel/sys_dp264.c | 6 ++++--
> arch/alpha/kernel/sys_titan.c | 3 ++-
> arch/arm/common/gic.c | 1 +
> arch/cris/arch-v32/kernel/irq.c | 1 +
> arch/ia64/kernel/iosapic.c | 3 +++
> arch/ia64/sn/kernel/irq.c | 3 +++
> arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
> arch/mips/sibyte/bcm1480/irq.c | 2 ++
> arch/mips/sibyte/sb1250/irq.c | 2 ++
> arch/powerpc/platforms/pseries/xics.c | 5 +++++
> arch/powerpc/sysdev/mpic.c | 2 ++
> arch/sparc/kernel/irq_64.c | 7 +++++++
> drivers/xen/events.c | 2 ++
> kernel/irq/manage.c | 6 ++----
> kernel/irq/migration.c | 8 +++-----
> 15 files changed, 45 insertions(+), 12 deletions(-)
Hm, this spreads a lot of instances of identical lines:
cpumask_copy(irq_desc[irq].affinity, mask_val);
all around architectures. How is that an improvement?
Ingo
next prev parent reply other threads:[~2009-04-08 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 22:37 [PATCH 1/2] irq: correct CPUMASKS_OFFSTACK typo -v2 Yinghai Lu
2009-04-03 22:39 ` [PATCH 2/2] irq: only update affinity in chip set_affinity() Yinghai Lu
2009-04-08 12:54 ` Ingo Molnar [this message]
2009-04-08 15:54 ` Yinghai Lu
2009-04-08 15:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408125415.GJ18581@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).