From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
Alexander Beregalov <a.beregalov@gmail.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] build fix for generic debug pagealloc
Date: Wed, 8 Apr 2009 15:05:10 +0200 [thread overview]
Message-ID: <20090408130510.GM18581@elte.hu> (raw)
In-Reply-To: <200904032238.55438.rjw@sisk.pl>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Friday 03 April 2009, Ingo Molnar wrote:
> >
> > * Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > > +config DEBUG_PAGEALLOC
> > > > + bool "Debug page memory allocations"
> > > > + depends on DEBUG_KERNEL && ARCH_SUPPORTS_DEBUG_PAGEALLOC
> > > > + depends on !HIBERNATION || !PPC && !SPARC
> > > > + ---help---
> > > > + Unmap pages from the kernel linear mapping after free_pages().
> > > > + This results in a large slowdown, but helps to find certain types
> > > > + of memory corruptions.
> > > > +
> > >
> > > I guess this is why it wasn't discovered in my compile testing.
> > > It's quite regrettable that `make allmodconfig' didn't enable the
> > > feature. That's what allmodconfig is for.
> >
> > Hm, i _do_ remember some hibernation magic fix from Rafael, in the
> > area of debugalloc. Many months ago.
> >
> > Rafael, is it supposed to work? If yes, i think we should unblock
> > it.
>
> Yes, it is, at least on x86.
>
> ISTR using DEBUG_PAGEALLOC with hibernation quite some time ago
> already.
Could you please send a patch to Andrew then to remove the above
dependency?
Ingo
prev parent reply other threads:[~2009-04-08 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 11:21 next-0402: build fails at mm/debug-pagealloc.c Alexander Beregalov
2009-04-02 16:31 ` [PATCH] build fix for generic debug pagealloc Akinobu Mita
2009-04-02 16:45 ` Andrew Morton
2009-04-03 16:44 ` Ingo Molnar
2009-04-03 20:38 ` Rafael J. Wysocki
2009-04-08 13:05 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408130510.GM18581@elte.hu \
--to=mingo@elte.hu \
--cc=a.beregalov@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rjw@sisk.pl \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).