From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler v2
Date: Wed, 8 Apr 2009 18:50:17 +0400 [thread overview]
Message-ID: <20090408145017.GB7556@lenovo> (raw)
If IRQ has no handler it remains non-Ack'ed even if APIC is not
requested for being disabled. Fix it.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
|more stuff needs fixing here first:
|
|arch/x86/kernel/irq.c: In function ‘do_IRQ’:
|arch/x86/kernel/irq.c:226: error: ‘disable_apic’ undeclared (first use in this
|function)
|arch/x86/kernel/irq.c:226: error: (Each undeclared identifier is reported only
|once
|arch/x86/kernel/irq.c:226: error: for each function it appears in.)
|
|like making 'disable_apic' available everywhere.
|
|Or better yet: introduce a dummy apic->write() method in the
|disable_apic=1 case so we can call a straight ack_APIC_irq().
|
| Ingo
Ingo, I think introducing additional dummy here would be a bit
expencive -- a number of callers of ack_APIC_irq just should not
check for disable_apic since it's not needed. disable_apic is to
depend on CONFIG_X86_LOCAL_APIC rather then CONFIG_X86_64 actually.
So make it then. Or you mean something else? Like new apic->write_eoi
operation? (I'm a bit tired so brain is a half functional now :)
arch/x86/kernel/irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.git/arch/x86/kernel/irq.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/irq.c
+++ linux-2.6.git/arch/x86/kernel/irq.c
@@ -223,10 +223,10 @@ unsigned int __irq_entry do_IRQ(struct p
irq = __get_cpu_var(vector_irq)[vector];
if (!handle_irq(irq, regs)) {
-#ifdef CONFIG_X86_64
+#ifdef CONFIG_X86_LOCAL_APIC
if (!disable_apic)
- ack_APIC_irq();
#endif
+ ack_APIC_irq();
if (printk_ratelimit())
printk(KERN_EMERG "%s: %d.%d No irq handler for vector (irq %d)\n",
next reply other threads:[~2009-04-08 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 14:50 Cyrill Gorcunov [this message]
2009-04-08 14:52 ` [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler v2 Ingo Molnar
2009-04-08 15:45 ` Cyrill Gorcunov
2009-04-08 15:55 ` Ingo Molnar
2009-04-08 16:21 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408145017.GB7556@lenovo \
--to=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).