From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: david-b@pacbell.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix RTC-CMOS message, now with SOB
Date: Thu, 9 Apr 2009 13:15:56 -0700 [thread overview]
Message-ID: <20090409131556.07c8eed9.akpm@linux-foundation.org> (raw)
In-Reply-To: <m3bprcusdw.fsf@intrepid.localdomain>
On Sat, 04 Apr 2009 21:32:27 +0200
Krzysztof Halasa <khc@pm.waw.pl> wrote:
> + (cmos_rtc.mon_alrm ? "alarms up to one year" :
> + cmos_rtc.day_alrm ? "alarms up to one month" :
> + "alarms up to one day") :
> + "no alarms";
>
> Feel free to use the following or your own version as long as the
> resulting message is correct.
> Thanks.
>
> Signed-off-by: Krzysztof Ha__asa <khc@pm.waw.pl>
Please resend the full changelog (possibly with updates) with each
updated version of a patch.
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -794,17 +794,15 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
> goto cleanup2;
> }
>
> - pr_info("%s: alarms up to one %s%s, %zd bytes nvram%s\n",
> - cmos_rtc.rtc->dev.bus_id,
> - is_valid_irq(rtc_irq)
> - ? (cmos_rtc.mon_alrm
> - ? "year"
> - : (cmos_rtc.day_alrm
> - ? "month" : "day"))
> - : "no",
> - cmos_rtc.century ? ", y3k" : "",
> - nvram.size,
> - is_hpet_enabled() ? ", hpet irqs" : "");
> + pr_info("%s: %s%s, %zd bytes nvram%s\n",
> + cmos_rtc.rtc->dev.bus_id,
> + !is_valid_irq(rtc_irq) ? "no alarms" :
> + cmos_rtc.mon_alrm ? "alarms up to one year" :
> + cmos_rtc.day_alrm ? "alarms up to one month" :
> + "alarms up to one day",
> + cmos_rtc.century ? ", y3k" : "",
> + nvram.size,
> + is_hpet_enabled() ? ", hpet irqs" : "");
>
> return 0;
The patch doesn't apply to current kernels (the driver core guys have
been running rampant again, methinks). Please redo, retest, resend?
Thanks.
next prev parent reply other threads:[~2009-04-09 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 16:52 [PATCH] fix RTC-CMOS message Krzysztof Halasa
2009-04-02 16:57 ` [PATCH] fix RTC-CMOS message, now with SOB Krzysztof Halasa
2009-04-04 18:02 ` David Brownell
2009-04-04 19:32 ` Krzysztof Halasa
2009-04-09 20:15 ` Andrew Morton [this message]
2009-04-14 21:53 ` Krzysztof Halasa
2009-04-15 13:31 ` [PATCH] fix RTC-CMOS message, against 2.6.30-rc2 Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409131556.07c8eed9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).