From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936697AbZDIUe7 (ORCPT ); Thu, 9 Apr 2009 16:34:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936344AbZDIUes (ORCPT ); Thu, 9 Apr 2009 16:34:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41357 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762291AbZDIUep (ORCPT ); Thu, 9 Apr 2009 16:34:45 -0400 Date: Thu, 9 Apr 2009 13:30:30 -0700 From: Andrew Morton To: Jan Kara Cc: yinghan@gmail.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, yinghan@google.com, nickpiggin@yahoo.com.au Subject: Re: [PATCH] ext2: Fix data corruption for racing writes Message-Id: <20090409133030.a7ea94c7.akpm@linux-foundation.org> In-Reply-To: <20090406102329.GD31189@duck.suse.cz> References: <1238715399-22172-1-git-send-email-jack@suse.cz> <20090406102329.GD31189@duck.suse.cz> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Apr 2009 12:23:29 +0200 Jan Kara wrote: > > > > I tried this patch and seems i got deadlock on the truncate_mutex. > > Here is the message after enabling lockdep. I pasted the same message > > on the origianal thread. > > ... > > I don't think this is a deadlock (or is the machine hung?). The thread > was just waiting for a long time. I'd think that you'll occasionally get > exactly the same message even without my patch if you stress the machine > like you do. > Well, it's easy to tell the difference deadlock: system never recovers long-sucky-delay: system eventually recovers. Which was it??