Re: [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.

From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.
Date: Thu, 9 Apr 2009 17:08:43 +0200	[thread overview]
Message-ID: <20090409150843.GA3111@cmpxchg.org> (raw)
In-Reply-To: <200904092018.GGD57377.FHJOLSMOFQOFVt@I-love.SAKURA.ne.jp>

On Thu, Apr 09, 2009 at 08:18:20PM +0900, Tetsuo Handa wrote:
> Is it legal to use '\t' and '\n' in filesystem's name?
> If legal, we should use \ooo escape for /proc/filesystems .
> 
> ----------
> [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.
> 
> Registering a filesystem with broken name
> 
>   static struct file_system_type dummy_fs_type = {
>           .name       = "a\tb\nc",
>   };
> 
> results in broken output
> 
>   # cat /proc/filesystems
>   nodev   sysfs
>   nodev   rootfs
>   nodev   bdev
>   nodev   proc
>   nodev   debugfs
>   nodev   sockfs
>   nodev   usbfs
>   nodev   pipefs
>   nodev   anon_inodefs
>   nodev   tmpfs
>   nodev   inotifyfs
>   nodev   devpts
>           ext3
>           ext2
>           cramfs
>   nodev   ramfs
>           vfat
>           iso9660
>   nodev   nfsd
>   nodev   smbfs
>   nodev   a       b
>   c
>   nodev   rpc_pipefs
> 
> Why not forbid '\t' and '\n'?

Which filesystem does that?  Shouldn't the filesystem get changed
instead?

	Hannes