From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
sam@ravnborg.org, linux-am33-list@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] MN10300: Move to arch/mn10300/include/asm/
Date: Thu, 9 Apr 2009 18:50:29 +0100 [thread overview]
Message-ID: <20090409175029.GC26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0904091028080.4583@localhost.localdomain>
On Thu, Apr 09, 2009 at 10:30:06AM -0700, Linus Torvalds wrote:
>
>
> On Thu, 9 Apr 2009, David Howells wrote:
> >
> > Move arch headers from include/asm-mn10300/ to arch/mn10300/include/asm/.
>
> This patch looks broken.
>
> It doesn't "move" anything at all. It just copies things, and leaves the
> old files alone.
>
> I wonder if you created the diff by doing
>
> git diff arch/mn10300
>
> because you had other changes pending that you didn't want to include?
>
> Regardless, I'm not applying something this obviously broken.
BTW, *please* use -M when posting that kind of patches. You'll end up with
several lines per moved file and "yes, this is just a move" immediately
obvious from the patch.
prev parent reply other threads:[~2009-04-09 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090409171447.3119.48356.stgit@warthog.procyon.org.uk>
2009-04-09 17:14 ` [PATCH 2/2] MN10300: Separate out the proc and unit header dirs from the general headers David Howells
2009-04-09 17:30 ` [PATCH 1/2] MN10300: Move to arch/mn10300/include/asm/ Linus Torvalds
2009-04-09 17:50 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409175029.GC26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).