From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andy Grover <andy.grover@oracle.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, npiggin@suse.de, akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] Document get_user_pages_fast()
Date: Fri, 10 Apr 2009 11:17:22 +0900 (JST) [thread overview]
Message-ID: <20090410110626.7931.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1239324283-4279-1-git-send-email-andy.grover@oracle.com>
> +/**
> + * get_user_pages_fast() - pin user pages in memory
> + * @start: starting user address
> + * @nr_pages: number of pages from start to pin
> + * @write: whether pages will be written to
> + * @pages: array that receives pointers to the pages pinned.
> + * Should be at least nr_pages long.
> + *
> + * Attempt to pin user pages in memory without taking mm->mmap_sem.
> + * If not successful, it will fall back to taking the lock and
> + * calling get_user_pages().
> + *
> + * Returns number of pages pinned. This may be fewer than the number
> + * requested. If nr_pages is 0 or negative, returns 0. If no pages
> + * were pinned, returns -errno.
> + */
> int __attribute__((weak)) get_user_pages_fast(unsigned long start,
> int nr_pages, int write, struct page **pages)
> {
There is one problem.
gup and get_page() don't provide any page pinning.
get_page() only gurantee not freed. but don't gurantee to prevent page
reclaim and Cow change owner process.
Yes, current all gup caller have serious bug. especially direct-io, aio, bio
are broken.
next prev parent reply other threads:[~2009-04-10 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 0:44 [PATCH 1/1] Document get_user_pages_fast() Andy Grover
2009-04-10 2:17 ` KOSAKI Motohiro [this message]
2009-04-10 3:13 ` Andrew Morton
2009-04-10 3:27 ` KOSAKI Motohiro
2009-04-10 4:13 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410110626.7931.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andy.grover@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).