From: Alexey Dobriyan <adobriyan@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andy Whitcroft <apw@canonical.com>,
akpm@linux-foundation.org, containers@lists.linux-foundation.org,
xemul@parallels.com, serue@us.ibm.com, dave@linux.vnet.ibm.com,
orenl@cs.columbia.edu, hch@infradead.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/30] ipcns: add create_ipc_ns()
Date: Fri, 10 Apr 2009 15:25:32 +0400 [thread overview]
Message-ID: <20090410112532.GB3311@x200.localdomain> (raw)
In-Reply-To: <20090410090149.GD17962@elte.hu>
On Fri, Apr 10, 2009 at 11:01:49AM +0200, Ingo Molnar wrote:
>
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > --- a/include/linux/ipc_namespace.h
> > +++ b/include/linux/ipc_namespace.h
> > @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
> >
> > #if defined(CONFIG_IPC_NS)
> > extern void free_ipc_ns(struct ipc_namespace *ns);
> > +struct ipc_namespace *create_ipc_ns(void);
> > extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> > struct ipc_namespace *ns);
> > extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
>
> Hm, doesnt the existing, correct pattern strike your eyes out:
>
> extern foo1();
> extern foo2();
> extern foo3();
>
> and then you add a new method in this inconsistent way:
>
> extern foo1();
> foox();
> extern foo2();
> extern foo3();
>
> Instead of continuing the existing pattern via:
>
> extern foo1();
> extern foox();
> extern foo2();
> extern foo3();
>
> ?
>
> I think we need a new checkpatch warning for such things. It might
> be a small detail in the big picture, but a thousand small details
> create a big mess easily so we have to try to get all the small
> details right, all the time - that is the only way to create a
> better kernel in the end.
We (OK, I don't care anyway) should remove extern in front of prototypes.
They slow down compilation, they make easier to overcome 80-column limit resulting in
multiline prototypes which are ugly.
next prev parent reply other threads:[~2009-04-10 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 2:33 [PATCH 04/30] ipcns: add create_ipc_ns() Alexey Dobriyan
2009-04-10 9:01 ` Ingo Molnar
2009-04-10 11:25 ` Alexey Dobriyan [this message]
2009-04-10 22:29 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410112532.GB3311@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=serue@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).