From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] lockdep: warn about lockdep disabling after kernel taint
Date: Fri, 10 Apr 2009 14:12:43 +0200 [thread overview]
Message-ID: <20090410121243.GO21506@elte.hu> (raw)
In-Reply-To: <1239312460-13396-1-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Impact: provide useful missing info for developers
>
> Kernel taint can occur in several situations such as warnings,
> load of prorietary or staging modules, bad page, etc...
>
> But when such taint happens, a developer might still be working on
> the kernel, expecting that lockdep is still enabled. But a taint
> disables lockdep without ever warning about it.
> Such a kernel behaviour doesn't really help for kernel development.
>
> This patch adds this missing warning.
>
> Since the taint is done most of the time after the main message that
> explain the real source issue, it seems safe to warn about it inside
> add_taint() so that it appears at last, without hurting the main
> information.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 3fd8c5b..9e7420a 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -213,8 +213,14 @@ unsigned long get_taint(void)
>
> void add_taint(unsigned flag)
> {
> - /* can't trust the integrity of the kernel anymore: */
> - debug_locks = 0;
> + /*
> + * Can't trust the integrity of the kernel anymore.
> + * We don't call directly debug_locks_off() because the issue
> + * is not necessarily serious enough to set oops_in_progress to 1
> + */
> + if (xchg(&debug_locks, 0))
> + printk(KERN_WARNING "Disabling lockdep due to kernel taint\n");
> +
nice idea - but please use the proper debug_locks_off() construct
instead of an open-coded xchg(). Something like:
if (debug_locks_off())
printk(...);
should do the trick.
Ingo
next prev parent reply other threads:[~2009-04-10 12:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 21:27 [PATCH 1/2] lockdep: warn about lockdep disabling after kernel taint Frederic Weisbecker
2009-04-09 21:27 ` [PATCH 2/2] lockdep: choose to continue lock debugging despite taint Frederic Weisbecker
2009-04-10 12:15 ` Ingo Molnar
2009-04-10 13:38 ` Frederic Weisbecker
2009-04-10 13:45 ` Ingo Molnar
2009-04-11 1:15 ` Frederic Weisbecker
2009-04-11 1:37 ` Frederic Weisbecker
2009-04-12 14:09 ` Ingo Molnar
2009-04-11 1:17 ` [PATCH 1/2 v2] lockdep: warn about lockdep disabling after kernel taint Frederic Weisbecker
2009-04-12 14:45 ` [tip:core/urgent] " Frederic Weisbecker
2009-04-11 1:17 ` [PATCH 2/2 v2] lockdep: continue lock debugging despite some taints Frederic Weisbecker
2009-04-12 14:45 ` [tip:core/urgent] " Frederic Weisbecker
2009-04-10 12:12 ` Ingo Molnar [this message]
2009-04-10 13:34 ` [PATCH 1/2] lockdep: warn about lockdep disabling after kernel taint Frederic Weisbecker
2009-04-10 13:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410121243.GO21506@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).