From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
xemul@parallels.com, dave@linux.vnet.ibm.com, mingo@elte.hu,
orenl@cs.columbia.edu, hch@infradead.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/30] nsproxy: add create_nsproxy()
Date: Fri, 10 Apr 2009 17:33:18 -0500 [thread overview]
Message-ID: <20090410223318.GB13873@us.ibm.com> (raw)
In-Reply-To: <20090410023413.GF27788@x200.localdomain>
Quoting Alexey Dobriyan (adobriyan@gmail.com):
> clone_nsproxy() does useless copying of old nsproxy -- every pointer
> will be rewritten to new ns or to old ns.
>
> Remove copying, rename clone_nsproxy(), it will be used by C/R code
> to create fresh nsproxy on restart.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
>
> kernel/nsproxy.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -26,19 +26,14 @@ static struct kmem_cache *nsproxy_cachep;
>
> struct nsproxy init_nsproxy = INIT_NSPROXY(init_nsproxy);
>
> -/*
> - * creates a copy of "orig" with refcount 1.
> - */
> -static inline struct nsproxy *clone_nsproxy(struct nsproxy *orig)
> +static inline struct nsproxy *create_nsproxy(void)
> {
> - struct nsproxy *ns;
> + struct nsproxy *nsproxy;
>
> - ns = kmem_cache_alloc(nsproxy_cachep, GFP_KERNEL);
> - if (ns) {
> - memcpy(ns, orig, sizeof(struct nsproxy));
> - atomic_set(&ns->count, 1);
> - }
> - return ns;
> + nsproxy = kmem_cache_alloc(nsproxy_cachep, GFP_KERNEL);
> + if (nsproxy)
> + atomic_set(&nsproxy->count, 1);
> + return nsproxy;
> }
>
> /*
> @@ -52,7 +47,7 @@ static struct nsproxy *create_new_namespaces(unsigned long flags,
> struct nsproxy *new_nsp;
> int err;
>
> - new_nsp = clone_nsproxy(tsk->nsproxy);
> + new_nsp = create_nsproxy();
> if (!new_nsp)
> return ERR_PTR(-ENOMEM);
prev parent reply other threads:[~2009-04-10 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 2:34 [PATCH 05/30] nsproxy: add create_nsproxy() Alexey Dobriyan
2009-04-10 22:33 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410223318.GB13873@us.ibm.com \
--to=serue@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).