From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
xemul@parallels.com, dave@linux.vnet.ibm.com, mingo@elte.hu,
orenl@cs.columbia.edu, hch@infradead.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/30] netns: extract net_create()
Date: Mon, 13 Apr 2009 11:11:11 +0400 [thread overview]
Message-ID: <20090413071111.GA7085@x200.localdomain> (raw)
In-Reply-To: <20090410225636.GD13873@us.ibm.com>
On Fri, Apr 10, 2009 at 05:56:36PM -0500, Serge E. Hallyn wrote:
> Quoting Alexey Dobriyan (adobriyan@gmail.com):
> > net_create() will be used by C/R code to create fresh netns on restart.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
>
> Although this ends up making a new assumption that setup_net(), and
> therefore the pernet_ops->init() functions, do not return error > 0.
> There's nothing actually stopping that (outside of code review, but
> there appears to be no comment anywhere saying that's uncooth).
>
> If it returns > 0, then we return the ns as though it were valid, but
> don't add it to the list of namespaces... Do we care?
I think, no.
Recalling all the code put under netns changes, ->init hooks were put
under 0/-E convention. For sure, my changes in netns xtables,
conntracking and xfrm were definitely under it.
> > -struct net *copy_net_ns(unsigned long flags, struct net *old_net)
> > +struct net *net_create(void)
prev parent reply other threads:[~2009-04-13 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 2:34 [PATCH 07/30] netns: extract net_create() Alexey Dobriyan
2009-04-10 9:04 ` Ingo Molnar
2009-04-10 22:56 ` Serge E. Hallyn
2009-04-13 7:11 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413071111.GA7085@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=serue@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).