From: Jarod Wilson <jarod@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH v2] crypto: add self-tests for rfc4309(ccm(aes))
Date: Wed, 15 Apr 2009 08:35:38 -0400 [thread overview]
Message-ID: <200904150835.38818.jarod@redhat.com> (raw)
In-Reply-To: <20090415112053.GA10188@gondor.apana.org.au>
On Wednesday 15 April 2009 07:20:53 Herbert Xu wrote:
> On Mon, Apr 13, 2009 at 07:11:00PM -0400, Jarod Wilson wrote:
> >
> > + case -EBADMSG:
> > + if (template[i].novrfy)
> > + /* verification failure was expected */
> > + goto next_aead_vector;
> > /* fall through */
>
> We should also fail if novrfy is true and we get a 0 return value.
Oh, yeah, whoops, missed that case. Will add that.
> I'd also prefer to have the novrfy infrastructure changes to go
> into a separate patch.
Yeah, wasn't sure if I should do infra separate or not. I'll split
things up a bit for the next submission that includes the catch for
novrfy true, ret 0.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2009-04-15 12:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 18:34 [PATCH] add self-tests for rfc4309(ccm(aes)) Jarod Wilson
2009-04-09 18:52 ` Neil Horman
2009-04-09 19:16 ` Jarod Wilson
2009-04-10 2:31 ` Neil Horman
2009-04-13 21:03 ` Jarod Wilson
2009-04-13 23:11 ` [PATCH v2] crypto: " Jarod Wilson
2009-04-14 11:13 ` Neil Horman
2009-04-15 11:20 ` Herbert Xu
2009-04-15 12:35 ` Jarod Wilson [this message]
2009-04-15 13:35 ` [PATCH 0/3] crypto: add testmgr support and self-tests for rfc4309 Jarod Wilson
2009-04-15 13:36 ` [PATCH 1/3] crypto: properly handle null input and assoc data aead test vectors Jarod Wilson
2009-04-20 6:23 ` Herbert Xu
2009-04-23 17:30 ` Jarod Wilson
2009-04-15 13:36 ` [PATCH 2/3] crypto: handle ccm dec test vectors expected to fail verification Jarod Wilson
2009-04-20 6:25 ` Herbert Xu
2009-04-23 17:31 ` Jarod Wilson
2009-04-15 13:37 ` [PATCH 3/3] crypto: add self-tests for rfc4309(ccm(aes)) Jarod Wilson
2009-04-20 6:26 ` Herbert Xu
2009-04-23 18:17 ` [PATCH v4 0/2] crypto: add testmgr support and self-tests for rfc4309 Jarod Wilson
2009-04-23 18:22 ` [PATCH 1/2] crypto: handle ccm dec test vectors expected to fail verification Jarod Wilson
2009-04-23 18:23 ` [PATCH 2/2] crypto: add self-tests for rfc4309(ccm(aes)) Jarod Wilson
2009-05-04 11:24 ` [PATCH v4 0/2] crypto: add testmgr support and self-tests for rfc4309 Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904150835.38818.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).