linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Constantin Baranov <const@mimas.ru>
To: Julian Calaby <julian.calaby@gmail.com>,
	James Bottomley <James.Bottomley@suse.de>
Cc: Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] hwmon: Driver for SCSI/ATA temperature sensors
Date: Wed, 16 Sep 2009 22:43:18 +0500	[thread overview]
Message-ID: <20090916224318.72be99ac.const@mimas.ru> (raw)
In-Reply-To: <646765f40909142257t560b314dt74d4158a497f0460@mail.gmail.com>

On Mon, 14 Sep 2009 17:00:20 +0200 Pavel Machek <pavel@ucw.cz> wrote:
> Well, having unified kernel<->user interface for temperature sensors
> makes sense.

This is my exact motivation.

On Tue, 15 Sep 2009 15:57:39 +1000 Julian Calaby <julian.calaby@gmail.com> wrote:
> On Mon, Sep 14, 2009 at 00:00, James Bottomley <James.Bottomley@suse.de> wrote:
> > So really, given the complexity of just obtaining the data and the
> > problem of matching which data to obtain to which device you have, why
> > not just use smartctl from userspace for monitoring?  you could even
> > just plug into smartd, it seems to have most of the necessary heuristics
> > built in already.
> 
> There's even a util called hddtemp which handles all this and has a
> database of smart attributes to use for most drives.

Of course, I know about both smartctl and hddtemp tools.

On Sun, 13 Sep 2009 09:00:53 -0500 James Bottomley <James.Bottomley@suse.de> wrote:
> The basic problem are the effects.  Right at the moment it tries to send
> an ATA_16 encapsulated SMART command to every SCSI device in the system.
> We simply can't allow this.  A huge number of SCSI presenting USB
> devices are known to lock up when they see either ATA_X encapsulation or
> SMART commands.  It's not really even safe to send ATA_X to SCSI
> devices.  The modern ones should all error out fine, but the older ones
> are likely to be less tolerant.

I looked for reliable method of classifying devices. Unfortunately,
without success. Maybe it's better to disable automatic scanning and provide
a user (udev) with ability to enable monitoring on explicitly pointed device.

> Smart attribute 194 is highly vendor specific ... for instance my new
> SATA drive doesn't implement it (it does implement 190 instead).

Unfortunately, every SMART attribute is either reserved or vendor specific
as per T13. AFAIK, 194 is the most popular. That's why I have chosen it
in the first version. However, attribute number (and interpretation method
as well) may become configurable. Moreover, we can use hddtemp database
to initially configure scsitemp. And use unified hwmon interface later :)

      reply	other threads:[~2009-09-16 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-12 23:01 [PATCH] hwmon: Driver for SCSI/ATA temperature sensors Constantin Baranov
2009-09-13  8:04 ` Rolf Eike Beer
2009-09-13 11:56   ` Constantin Baranov
2009-09-13 14:00 ` James Bottomley
2009-09-14 15:00   ` Pavel Machek
2009-09-15  5:57   ` Julian Calaby
2009-09-16 17:43     ` Constantin Baranov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090916224318.72be99ac.const@mimas.ru \
    --to=const@mimas.ru \
    --cc=James.Bottomley@suse.de \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).