From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, michael.hennerich@analog.com,
cooloney@kernel.org
Subject: Re: [PATCH v2] fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver
Date: Thu, 24 Sep 2009 16:32:40 -0700 [thread overview]
Message-ID: <20090924163240.d03127e3.akpm@linux-foundation.org> (raw)
In-Reply-To: <1253223426-5938-1-git-send-email-vapier@gentoo.org>
On Thu, 17 Sep 2009 17:37:06 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Framebuffer driver for the Landscape LCD EZ-Extender (ADZS-BFLLCD-EZEXT)
> http://docs.blackfin.uclinux.org/doku.php?id=hw:cards:landscape_lcd_ez-extender
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> ...
>
> +config FB_BFIN_LQ035Q1
> + tristate "SHARP LQ035Q1DH02 TFT LCD"
> + depends on FB && BLACKFIN
> + select FB_CFB_FILLRECT
> + select FB_CFB_COPYAREA
> + select FB_CFB_IMAGEBLIT
> + select BFIN_GPTIMERS
> + select SPI
Are we sure about the `select SPI'? There's only one other place in
the kernel which does this, and `select' often makes things explode. I
fear that you're either selecting the wrong thing or you're selecting
something which won't work well.
> + help
> + This is the framebuffer device driver for a SHARP LQ035Q1DH02 TFT display found on
> + the Blackfin Landscape LCD EZ-Extender Card.
> + This display is a QVGA 320x240 18-bit RGB display interfaced by an 16-bit wide PPI
> + It uses PPI[0..15] PPI_FS1, PPI_FS2 and PPI_CLK.
>
>
> ...
>
> +
> +#define DRIVER_NAME "bfin-lq035q1"
> +static char driver_name[] = DRIVER_NAME;
Will the compielr magically put this string into read-only storage for
us, or should we do that manually with `const'?
>
> ...
>
> +static int lq035q1_control(unsigned char reg, unsigned short value)
> +{
> + int ret;
> + u8 regs[3] = {LQ035_INDEX, 0, 0};
> + u8 dat[3] = {LQ035_DATA, 0, 0};
> +
> + if (spi_control.spidev) {
> + regs[2] = reg;
> + dat[1] = value >> 8;
> + dat[2] = value & 0xFF;
> +
> + ret = spi_write(spi_control.spidev, regs, ARRAY_SIZE(regs));
> + ret |= spi_write(spi_control.spidev, dat, ARRAY_SIZE(dat));
> + } else
> + return -ENODEV;
> +
> + return ret;
> +}
I am suspecting that this function (and the similar ones below) rely
upon state within the hardware and will hence misbehave if two
instances are run concurrently.
Is that correct> If so, is there locking to prevent this from occurring?
>
> ...
>
next prev parent reply other threads:[~2009-09-24 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 17:49 [PATCH] fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver Mike Frysinger
2009-09-14 17:49 ` [PATCH] fbdev: bfin-t350mcqb-fb: handle all resources in suspend/resume Mike Frysinger
2009-09-14 17:49 ` [PATCH] fbdev: bfin-t350mcqb-fb: fix LCD dimensions Mike Frysinger
2009-09-17 21:37 ` [PATCH v2] fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver Mike Frysinger
2009-09-24 23:32 ` Andrew Morton [this message]
2009-09-25 20:24 ` Mike Frysinger
2009-09-25 20:48 ` Mike Frysinger
2009-10-01 5:44 ` [PATCH 1/3 " Mike Frysinger
2009-10-06 6:02 ` [PATCH v4] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090924163240.d03127e3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).