From: Wolfram Sang <w.sang@pengutronix.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
Linux PCI <linux-pci@vger.kernel.org>,
linux-pcmcia@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Florian <fs-kernelbugzilla@spline.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] PM / PCMCIA: Drop second argument of pcmcia_socket_dev_suspend()
Date: Mon, 28 Sep 2009 13:31:12 +0200 [thread overview]
Message-ID: <20090928113112.GA5602@pengutronix.de> (raw)
In-Reply-To: <200909260125.11149.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Sat, Sep 26, 2009 at 01:25:11AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> pcmcia_socket_dev_suspend() doesn't use its second argument, so it
> may be dropped safely.
>
> This change is necessary for the subsequent yenta suspend/resume fix.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/pcmcia/at91_cf.c | 2 +-
> drivers/pcmcia/au1000_generic.c | 2 +-
> drivers/pcmcia/bfin_cf_pcmcia.c | 2 +-
> drivers/pcmcia/cs.c | 2 +-
> drivers/pcmcia/i82092.c | 2 +-
> drivers/pcmcia/i82365.c | 2 +-
> drivers/pcmcia/m32r_cfc.c | 2 +-
> drivers/pcmcia/m32r_pcc.c | 2 +-
> drivers/pcmcia/m8xx_pcmcia.c | 2 +-
> drivers/pcmcia/omap_cf.c | 2 +-
> drivers/pcmcia/pd6729.c | 2 +-
> drivers/pcmcia/pxa2xx_base.c | 2 +-
> drivers/pcmcia/sa1100_generic.c | 2 +-
> drivers/pcmcia/sa1111_generic.c | 2 +-
> drivers/pcmcia/tcic.c | 2 +-
> drivers/pcmcia/vrc4171_card.c | 2 +-
> include/pcmcia/ss.h | 2 +-
Hmm, you are not converting yenta_socket here. Won't that break building the
kernel (git bisect)?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-09-28 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 23:22 [PATCH 0/2] PM / PCMCIA: Fix CardBus suspend/resume regression Rafael J. Wysocki
2009-09-25 23:25 ` [PATCH 1/2] PM / PCMCIA: Drop second argument of pcmcia_socket_dev_suspend() Rafael J. Wysocki
2009-09-28 11:31 ` Wolfram Sang [this message]
2009-09-28 20:16 ` Rafael J. Wysocki
2009-09-25 23:26 ` [PATCH 2/2] PM / yenta: Fix cardbus suspend/resume regression Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928113112.GA5602@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=fs-kernelbugzilla@spline.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).