LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	Arnd Hannemann <Arnd.Hannemann@nets.rwth-aachen.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-geode@lists.infradead.org"
	<linux-geode@lists.infradead.org>
Subject: Re: 2.6.33-rc3 regression: leds_alix2: can't allocate I/O for GPIO
Date: Sun, 10 Jan 2010 13:27:54 +0100
Message-ID: <20100110122754.GC8970@buzzloop.caiaq.de> (raw)
In-Reply-To: <4B46EDA1.4030902@nets.rwth-aachen.de>

On Fri, Jan 08, 2010 at 09:32:33AM +0100, Arnd Hannemann wrote:
> Daniel Mack schrieb:

[...]

> > From ebb89d7d1908e85587f3e64bcea0dd77a92cc744 Mon Sep 17 00:00:00 2001
> > From: Daniel Mack <daniel@caiaq.de>
> > Date: Fri, 8 Jan 2010 02:22:10 +0800
> > Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335
> > 
> > The ALIX2 LED driver and the CS5535 GPIO driver share the same I/O
> > range which causes a conflict if they're both enabled. Fix this for now
> > by adding a Kconfig dependency. While at it, also drop the EXPERIMENTAL
> > flag, as the code has been around for awhile already.
> > 
> > Note that this is a hack. At some point, a real platform support for
> > this board should be added which handles the LEDs via the leds-gpio
> > driver.
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Cc: Richard Purdie <rpurdie@rpsys.net>
> > Cc: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
> > ---
> >  drivers/leds/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index 8a0e1ec..7f292ae 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -72,7 +72,7 @@ config LEDS_WRAP
> >  
> >  config LEDS_ALIX2
> >  	tristate "LED Support for ALIX.2 and ALIX.3 series"
> > -	depends on LEDS_CLASS && X86 && EXPERIMENTAL
> > +	depends on LEDS_CLASS && X86 && !GPIO_CS5535
> 
> You should add && !CS5535_GPIO, too. In fact CS5535_GPIO
> was the one that I had issues with. Though, I wonder why
> there are multiple drivers... Buts thats another issue.

Ah, right, thanks for noticing. New patch below.

Daniel


>From 0ce35578c6705dd1c44d076529df6dba889b7b76 Mon Sep 17 00:00:00 2001
From: Daniel Mack <daniel@caiaq.de>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO drivers share the same I/O
range which causes a conflict if they're both enabled. Fix this for now
by adding Kconfig dependencies. While at it, also drop the EXPERIMENTAL
flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for
this board should be added which handles the LEDs via the leds-gpio
driver.

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 8a0e1ec..fef1cf4 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535 && !CS5535_GPIO
 	help
 	  This option enables support for the PCEngines ALIX.2 and ALIX.3 LEDs.
 	  You have to set leds-alix2.force=1 for boards with Award BIOS.
-- 
1.6.3.3


  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 10:26 Arnd Hannemann
2010-01-07 10:51 ` Richard Purdie
2010-01-07 11:58   ` Arnd Hannemann
2010-01-07 12:11     ` Arnd Hannemann
2010-01-07 12:46       ` Daniel Mack
2010-01-07 14:00         ` Arnd Hannemann
2010-01-07 14:20           ` Daniel Mack
2010-01-07 17:27           ` Richard Purdie
2010-01-08  3:08             ` Daniel Mack
2010-01-08  8:32               ` Arnd Hannemann
2010-01-10 12:27                 ` Daniel Mack [this message]
2010-01-16 18:52                   ` Daniel Mack
2010-01-18 13:59                   ` Richard Purdie

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100110122754.GC8970@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=Arnd.Hannemann@nets.rwth-aachen.de \
    --cc=hannemann@nets.rwth-aachen.de \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git