From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989Ab0AKWtn (ORCPT ); Mon, 11 Jan 2010 17:49:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752139Ab0AKWtn (ORCPT ); Mon, 11 Jan 2010 17:49:43 -0500 Received: from bld-mail17.adl2.internode.on.net ([150.101.137.102]:60321 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751546Ab0AKWtm (ORCPT ); Mon, 11 Jan 2010 17:49:42 -0500 Date: Tue, 12 Jan 2010 09:49:38 +1100 From: Dave Chinner To: Andi Kleen Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Allow linker to eliminate unused functions in lib/* Message-ID: <20100111224938.GA16080@discord.disaster> References: <20100105145917.GA25570@basil.fritz.box> <20100108162930.a011749a.akpm@linux-foundation.org> <20100109165155.GD20773@basil.fritz.box> <20100110231708.GC4019@discord.disaster> <20100111142412.GA28783@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100111142412.GA28783@one.firstfloor.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2010 at 03:24:12PM +0100, Andi Kleen wrote: > On Mon, Jan 11, 2010 at 10:17:08AM +1100, Dave Chinner wrote: > > On Sat, Jan 09, 2010 at 05:51:56PM +0100, Andi Kleen wrote: > > > > Sneaky. > > > > > > > > It's a bit sad to reduce the code cleanliness and maintainability in > > > > this way, but 1k is 1k. > > > > > > Yes. I had actually hoped for more too. I think it might bring > > > more with -ffunction-sections/--gc-sections, but I haven't tried that. > > > > > > An alternative might be also to give some more of those explicit Kconfig > > > symbols -- then kernels with module loading enabled would benefit more > > > too -- but I haven't investigated how many changes that would need. > > > > > > But even with that it's a reasonable improvement and putting the exports > > > separately is not too bad. > > > > > > > The patch assumes a pre-existing lib-syms.c. Confused. > > > > > > Sorry, some day I'll learn how to operate quilt properly. > > > > > > Updated patch with all files included appended. > > > > Andi, how do you want to handle the overlap between this and the > > list_sort() patch I sent? I'm going to need a list_sort() available > > in the XFS tree well before the 2.6.34 merge window.... > > Shouldn't be difficult to merge, it's just a few lines. Someone will > do that. > > It wou;ld be better if you put it into a separate file like I suggested > earlier though, then the list_sort() could be actually eliminated when > not needed. OK, I'll respin it to do that, then push it onwards. Cheers, Dave. -- Dave Chinner david@fromorbit.com