From: David Miller <davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shemminger@vyatta.com
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
Date: Sat, 16 Jan 2010 01:20:04 -0800 (PST) [thread overview]
Message-ID: <20100116.012004.166836523.davem@davemloft.net> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D021A4A@MORGANITE.micrel.com>
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Fri, 15 Jan 2010 18:57:59 -0800
> The KSZ8842 has a switch with lots of hardware configurations. The =
> driver uses the proc system to allow users to configure the switch. If =
> this is not desired the whole thing can be removed by not calling the =
> init_proc() function.
I think there needs to be a serious discussion about how
this driver uses bridge layer internals by doing things like:
+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif
and uses procfs to configure the ports.
Stephen please look this over and make suggestions for better
ways to support and configure these kinds of devices.
Thanks.
next prev parent reply other threads:[~2010-01-16 9:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 2:57 [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver Ha, Tristram
2010-01-16 9:20 ` David Miller [this message]
2010-01-19 20:03 ` Ha, Tristram
2010-01-19 21:40 ` Stephen Hemminger
2010-01-19 23:48 ` Ha, Tristram
2010-01-20 0:11 ` Stephen Hemminger
2010-01-20 0:34 ` Ha, Tristram
2010-01-20 0:50 ` Stephen Hemminger
2010-01-16 14:50 ` Alan Cox
2010-01-19 21:22 ` Ha, Tristram
2010-01-19 21:32 ` Alan Cox
2010-01-20 0:12 ` Ha, Tristram
2010-01-16 16:00 ` Michał Mirosław
2010-01-16 16:16 ` Felix Fietkau
2010-01-19 21:51 ` Ha, Tristram
2010-01-19 22:11 ` Felix Fietkau
2010-02-08 21:36 Ha, Tristram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116.012004.166836523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@Micrel.Com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).