From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Uwe Geuder <ubuntuLp-ugeuder@sneakemail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] console/vgacon.c: mark file-local symbol static.
Date: Sun, 17 Jan 2010 01:18:22 +0000 [thread overview]
Message-ID: <20100117011822.GA6272@srcf.ucam.org> (raw)
In-Reply-To: <1c1713c0724e7a7283fce34b0d23a2eaa929df10.1263682176.git.tfransosi@gmail.com>
On Sat, Jan 16, 2010 at 05:52:13PM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> drivers/video/console/vgacon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index cc4bbbe..19e474d 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -112,7 +112,7 @@ static int vga_video_font_height;
> static int vga_scan_lines __read_mostly;
> static unsigned int vga_rolled_over;
>
> -int vgacon_text_mode_force = 0;
> +static int vgacon_text_mode_force = 0;
Should probably lose the assignment while we're at it?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-01-17 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 22:52 [PATCH] console/vgacon.c: mark file-local symbol static Thiago Farina
2010-01-17 1:18 ` Matthew Garrett [this message]
2010-01-17 13:36 ` Thiago Farina
2010-01-17 19:31 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117011822.GA6272@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tfransosi@gmail.com \
--cc=ubuntuLp-ugeuder@sneakemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).