From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928Ab0ARCDn (ORCPT ); Sun, 17 Jan 2010 21:03:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752268Ab0ARCDm (ORCPT ); Sun, 17 Jan 2010 21:03:42 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:60772 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab0ARCDl (ORCPT ); Sun, 17 Jan 2010 21:03:41 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Mon, 18 Jan 2010 11:00:19 +0900 From: KAMEZAWA Hiroyuki To: OGAWA Hirofumi Cc: Wu Fengguang , Andrew Morton , Al Viro , Heiko Carstens , Christoph Hellwig , LKML , Eric Paris , Nick Piggin , Andi Kleen , David Howells , Jonathan Corbet , Subject: Re: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos Message-Id: <20100118110019.c55ad88a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <87pr58kx9o.fsf@devron.myhome.or.jp> References: <20100115013954.311049665@intel.com> <20100115014422.959401729@intel.com> <87bpgurz00.fsf@devron.myhome.or.jp> <20100118091527.7a0e2c6e.kamezawa.hiroyu@jp.fujitsu.com> <87y6jwnrcz.fsf@devron.myhome.or.jp> <20100118102544.3e897525.kamezawa.hiroyu@jp.fujitsu.com> <87pr58kx9o.fsf@devron.myhome.or.jp> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jan 2010 10:38:27 +0900 OGAWA Hirofumi wrote: > KAMEZAWA Hiroyuki writes: > > >> So, lseek() returns (uses) it? > > > > lseek can return negative value, as far as I know. > > Umm..., how do you know the difference of -EOVERFLOW and fpos == -75? > Ah, sorry. I read wrong. For /dev/mem, it uses its own lseek function which allows negative f_pos value. Other usual file system doesn't allow negative f_pos. It's ok not to return -EOVEFLOW for /dev/mem because there is no file end. Thanks, -Kame