From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bonbons@linux-vserver.org, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vlan: fix vlan_skb_recv()
Date: Sun, 24 Jan 2010 19:52:36 -0800 (PST) [thread overview]
Message-ID: <20100124.195236.40118964.davem@davemloft.net> (raw)
In-Reply-To: <4B5CA2CA.4040307@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 24 Jan 2010 20:43:06 +0100
> [PATCH] vlan: fix vlan_skb_recv()
>
> Bruno Prémont found commit 9793241fe92f7d930
> (vlan: Precise RX stats accounting) added a regression for non
> hw accelerated vlans.
>
> [ 26.390576] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 26.396369] IP: [<df856b89>] vlan_skb_recv+0x89/0x280 [8021q]
>
> vlan_dev_info() was used with original device, instead of
> skb->dev. Also spotted by Américo Wang.
>
> Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
> Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2010-01-25 3:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 15:56 [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267 Bruno Prémont
2010-01-23 21:31 ` Bruno Prémont
2010-01-24 13:42 ` Eric Dumazet
2010-01-24 15:02 ` Bruno Prémont
2010-01-24 15:25 ` Bruno Prémont
2010-01-24 16:25 ` Américo Wang
2010-01-24 16:27 ` Eric Dumazet
2010-01-24 16:26 ` Eric Dumazet
2010-01-24 19:18 ` Bruno Prémont
2010-01-24 19:43 ` [PATCH] vlan: fix vlan_skb_recv() Eric Dumazet
2010-01-25 3:52 ` David Miller [this message]
2010-01-24 7:12 ` [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267 Américo Wang
2010-01-24 7:17 ` Alexey Dobriyan
2010-01-24 7:30 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100124.195236.40118964.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonbons@linux-vserver.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).