From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753652Ab0BAWqs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2010 17:46:48 -0500
Received: from fg-out-1718.google.com ([72.14.220.158]:43418 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751993Ab0BAWqq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2010 17:46:46 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=U7D9YMx10PMrPffss1MD/HnCi94FRAHk8peBtbevzitS6rzxdjXilq2rCudxSPpOWF
         XR3QrLKiHDd7L6Ldpk9cLItGHfk+9lBMpHCDkP8N9bnsKqjdlciWNLaPmBWhmYSkReYO
         +hpWCJNPRHUhJdCH0ZZGCfJmBwFCKJwZvsqYg=
Date: Mon, 1 Feb 2010 23:46:39 +0100
From: Jarek Poplawski <jarkao2@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Michael Breuer <mbreuer@majjas.com>, David Miller <davem@davemloft.net>,
       akpm@linux-foundation.org, flyboy@gmail.com,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       Michael Chan <mchan@broadcom.com>, Don Fry <pcnet32@verizon.net>,
       Francois Romieu <romieu@fr.zoreil.com>,
       Matt Carlson <mcarlson@broadcom.com>
Subject: Re: [PATCH v3] sky2:  receive dma mapping error handling
Message-ID: <20100201224639.GA4664@del.dom.local>
References: <20100128153643.0fca3c51@nehalam>
 <4B645EF4.4050701@majjas.com>
 <20100131003449.GA11935@del.dom.local>
 <4B650D53.2010607@majjas.com>
 <4B65D0F9.2020602@majjas.com>
 <4B65FD12.7090101@majjas.com>
 <20100131221835.GA3317@del.dom.local>
 <20100201102018.7b597992@nehalam>
 <20100201212740.GA3289@del.dom.local>
 <20100201142942.710273cf@nehalam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100201142942.710273cf@nehalam>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 01, 2010 at 02:29:42PM -0800, Stephen Hemminger wrote:
> On Mon, 1 Feb 2010 22:27:41 +0100
> Jarek Poplawski <jarkao2@gmail.com> wrote:
> 
> > @@ -1038,13 +1035,14 @@ static void tx_init(struct sky2_port *sky2)
> >  {
> >  	struct sky2_tx_le *le;
> >  
> > -	sky2->tx_prod = sky2->tx_cons = 0;
> > +	sky2->tx_prod = 0;
> >  	sky2->tx_tcpsum = 0;
> >  	sky2->tx_last_mss = 0;
> >  
> >  	le = get_tx_le(sky2, &sky2->tx_prod);
> >  	le->addr = 0;
> >  	le->opcode = OP_ADDR64 | HW_OWNER;
> > +	sky2->tx_cons = sky2->tx_prod;
> >  	sky2->tx_last_upper = 0;
> >  }
> 
> Your change causes the initial element to be skipped. I want
> it to goto the hardware. It makes sure the upper bits of the
> first request are set (0).

I thought "Send high bits if needed" part in sky2_xmit_frame() was
enough. If it's otherwise than my patch was wrong.

> 
> I don't see what was wrong with my fix.
> 
It's OK. Please, submit it instead of mine.

Thanks,
Jarek P.