From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Heinz Diehl <htd@fancy-poultry.org>
Cc: Xiaotian Feng <xtfeng@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
nhorman@tuxdriver.com, davem@davemloft.net
Subject: Re: [Bug #15196] kmem_cache_create: duplicate cache ccid2_h
Date: Sun, 7 Feb 2010 12:42:03 +0100 [thread overview]
Message-ID: <201002071242.03698.rjw@sisk.pl> (raw)
In-Reply-To: <20100207105448.GA6623@fancy-poultry.org>
On Sunday 07 February 2010, Heinz Diehl wrote:
> On 01.02.2010, Heinz Diehl wrote:
>
> [....]
>
> Quoting myself here...
>
> > The patch was completely malformed, don't know what happened on the way,
> > but I applied it by hand. Yes, it fixes the problem for me.
>
> Xiaotiangs patch quoted in the thread listed here (coming via kernel.org's
> bugtracker)
>
> http://patchwork.kernel.org/patch/76023/
>
> is missing some lines, and the patch attached at the end of the
> thread is incomplete and malformed, as reported earlier. I guess this is
> how it should have looked like (please correct me if I'm wrong):
Thanks, I updated the bug entry with a link to your patch below.
> --- /a/ccid.c 2010-02-06 23:17:12.000000000 +0100
> +++ /b/ccid.c 2010-02-07 09:50:40.000000000 +0100
> @@ -77,13 +77,13 @@
> return err;
> }
>
> -static struct kmem_cache *ccid_kmem_cache_create(int obj_size, char *slab_name_fmt, const char *fmt,...)
> +static struct kmem_cache *ccid_kmem_cache_create(int obj_size, char *slab_name_fmt, int length, const char *fmt,...)
> {
> struct kmem_cache *slab;
> va_list args;
>
> va_start(args, fmt);
> - vsnprintf(slab_name_fmt, sizeof(slab_name_fmt), fmt, args);
> + vsnprintf(slab_name_fmt, length, fmt, args);
> va_end(args);
>
> slab = kmem_cache_create(slab_name_fmt, sizeof(struct ccid) + obj_size, 0,
> @@ -104,6 +104,7 @@
> ccid_ops->ccid_hc_rx_slab =
> ccid_kmem_cache_create(ccid_ops->ccid_hc_rx_obj_size,
> ccid_ops->ccid_hc_rx_slab_name,
> + sizeof(ccid_ops->ccid_hc_rx_slab_name),
> "ccid%u_hc_rx_sock",
> ccid_ops->ccid_id);
> if (ccid_ops->ccid_hc_rx_slab == NULL)
> @@ -112,6 +113,7 @@
> ccid_ops->ccid_hc_tx_slab =
> ccid_kmem_cache_create(ccid_ops->ccid_hc_tx_obj_size,
> ccid_ops->ccid_hc_tx_slab_name,
> + sizeof(ccid_ops->ccid_hc_tx_slab_name),
> "ccid%u_hc_tx_sock",
> ccid_ops->ccid_id);
> if (ccid_ops->ccid_hc_tx_slab == NULL)
>
Rafael
next prev parent reply other threads:[~2010-02-07 11:41 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 0:18 2.6.33-rc6: Reported regressions from 2.6.32 Rafael J. Wysocki
2010-02-01 0:19 ` [Bug #14791] Something has been broken in the network stack this week Rafael J. Wysocki
2010-02-01 0:46 ` Ben Hutchings
2010-02-01 0:22 ` [Bug #14937] WARNING: at kernel/lockdep.c:2830 Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #14792] Misdetection of the TV output Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15036] soft lockup in dmesg after suspend/resume Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #14950] tbench regression with 2.6.33-rc1 Rafael J. Wysocki
2010-02-01 7:57 ` Mike Galbraith
2010-02-02 20:45 ` Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #14949] drm_vm.c:drm_mmap: possible circular locking dependency detected Rafael J. Wysocki
2010-02-01 18:01 ` Borislav Petkov
2010-02-02 20:46 ` Rafael J. Wysocki
2010-02-02 20:58 ` Borislav Petkov
2010-02-02 21:12 ` Rafael J. Wysocki
2010-02-03 2:18 ` Greg KH
2010-02-01 0:22 ` [Bug #15039] leds_alix2: can't allocate I/O for GPIO Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #14999] possible circular locking dependency detected in rfkill at suspend Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15025] Oops in ext4 driver Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15076] System panic under load with clockevents_program_event Rafael J. Wysocki
2010-02-01 7:15 ` okias
2010-02-02 20:44 ` Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15043] Display goes off with i915.powersave=1 after suspend-resume Rafael J. Wysocki
2010-02-04 20:08 ` Soeren Sonnenburg
2010-02-04 20:42 ` Rafael J. Wysocki
2010-02-05 19:29 ` Jesse Barnes
2010-02-06 5:11 ` Soeren Sonnenburg
2010-02-06 5:53 ` Soeren Sonnenburg
2010-02-01 0:22 ` [Bug #15114] X.org hang with [drm:i915_gem_do_execbuffer] *ERROR* in dmesg Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15119] iwl_bg_scan_completed: WARN on scan complete Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15124] PCI host bridge windows ignored (works with pci=use_crs) Rafael J. Wysocki
2010-02-01 5:40 ` Yinghai Lu
2010-02-02 20:42 ` Rafael J. Wysocki
2010-02-02 20:50 ` Jeff Garrett
2010-02-02 21:13 ` Rafael J. Wysocki
2010-02-02 20:55 ` Bjorn Helgaas
2010-02-02 21:15 ` Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15139] e1000: transmit queue 0 timed out Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15125] hung task - jbd2/dm-1-8 (during raid rebuild) Rafael J. Wysocki
2010-02-01 0:42 ` Michael Breuer
2010-02-01 17:39 ` Michael Breuer
2010-02-02 20:42 ` Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15138] evdev regression on macbook Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15142] "INFO: possible circular locking dependency detected" Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15144] HDA Intel Audio hang on boot Rafael J. Wysocki
2010-02-01 2:01 ` Sid Boyce
2010-02-01 6:43 ` Takashi Iwai
2010-02-02 20:40 ` Rafael J. Wysocki
2010-02-03 2:37 ` Sid Boyce
2010-02-14 20:29 ` Sid Boyce
2010-02-14 21:50 ` Rafael J. Wysocki
2010-02-15 7:12 ` yTakashi Iwai
2010-02-15 12:46 ` Sid Boyce
2010-02-15 12:53 ` Takashi Iwai
2010-02-15 13:51 ` Sid Boyce
2010-02-15 16:08 ` Takashi Iwai
2010-02-01 0:22 ` [Bug #15192] netperf ~50% regression with 2.6.33-rc1, bisect to 1b9508f Rafael J. Wysocki
2010-02-01 8:04 ` Mike Galbraith
2010-02-02 20:38 ` Rafael J. Wysocki
2010-02-20 7:52 ` Lin Ming
2010-02-22 4:59 ` Mike Galbraith
2010-02-01 0:22 ` [Bug #15195] kernel BUG at include/net/netns/generic.h:41, pfkey_create+0x36/0x18b [af_key] Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15199] sata_nv and no /dev files Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15200] NFS problems in 2.6.33-rc6: Unknown error 526 Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15198] Radeon KMS regression Rafael J. Wysocki
2010-02-02 0:04 ` Kevin Winchester
2010-02-02 20:25 ` Rafael J. Wysocki
2010-02-01 0:22 ` [Bug #15196] kmem_cache_create: duplicate cache ccid2_h Rafael J. Wysocki
2010-02-01 3:30 ` Xiaotian Feng
2010-02-01 7:20 ` David Miller
2010-02-01 11:55 ` Neil Horman
2010-02-01 12:49 ` David Miller
2010-02-01 13:01 ` Neil Horman
2010-02-01 15:06 ` Heinz Diehl
2010-02-07 10:54 ` Heinz Diehl
2010-02-07 11:42 ` Rafael J. Wysocki [this message]
2010-02-01 0:22 ` [Bug #15202] lockdep warning during elevator_switch Rafael J. Wysocki
2010-02-07 22:16 2.6.33-rc7: Reported regressions from 2.6.32 Rafael J. Wysocki
2010-02-07 22:28 ` [Bug #15196] kmem_cache_create: duplicate cache ccid2_h Rafael J. Wysocki
2010-02-08 7:15 ` Heinz Diehl
2010-02-08 11:04 ` Rafael J. Wysocki
2010-02-08 20:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002071242.03698.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=davem@davemloft.net \
--cc=htd@fancy-poultry.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).