From: David Miller <davem@davemloft.net>
To: rob@landley.net
Cc: qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com,
atar4qemu@googlemail.com, linux-kernel@vger.kernel.org,
sam@ravnborg.org
Subject: Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.
Date: Sun, 21 Feb 2010 15:57:19 -0800 (PST) [thread overview]
Message-ID: <20100221.155719.226789440.davem@davemloft.net> (raw)
In-Reply-To: <201002211025.11588.rob@landley.net>
From: Rob Landley <rob@landley.net>
Date: Sun, 21 Feb 2010 10:25:09 -0600
> 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit
> commit 085219f79cad89291699bd2bfb21c9fdabafe65f
> Author: Sam Ravnborg <sam@ravnborg.org>
> Date: Fri Jan 2 18:47:34 2009 -0800
>
> sparc32: use proper types in struct stat
>
> Like sparc64 use proper types in struct stat
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> This commit breaks stat and makes sparc32 essentially unusable. It changes
> the size of the various types in stat.h, and means that if you "mount -t tmpfs
> /tmp /tmp" and then try to ls /tmp, ls dies with a memory allocation error.
>
> I've confirmed that reverting it fixes the problem.
Thanks for tracking this down Rob, I'll work on a fix and
push it around.
next prev parent reply other threads:[~2010-02-21 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201002110520.07620.rob@landley.net>
[not found] ` <f43fc5581002201359x50aff2b1ofc4f816762bda597@mail.gmail.com>
[not found] ` <201002201712.23628.rob@landley.net>
2010-02-21 16:25 ` Commit 085219f79cad broke Sparc-32 back in 2.6.28 Rob Landley
2010-02-21 23:57 ` David Miller [this message]
2010-02-22 0:28 ` Bartlomiej Zolnierkiewicz
2010-02-22 2:03 ` Rob Landley
2010-02-22 2:06 ` David Miller
2010-03-27 3:35 ` Rob Landley
2010-03-27 3:37 ` David Miller
2010-03-27 7:44 ` Rob Landley
2010-03-27 23:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221.155719.226789440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atar4qemu@googlemail.com \
--cc=blauwirbel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rob@landley.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).