From: Fabio Checconi <fchecconi@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Paul Turner <pjt@google.com>,
Dario Faggioli <faggioli@gandalf.sssup.it>,
Michael Trimarchi <michael@evidence.eu.com>,
Dhaval Giani <dhaval@retis.sssup.it>,
Tommaso Cucinotta <t.cucinotta@sssup.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sched: enforce per-cpu utilization limits on runtime balancing
Date: Wed, 3 Mar 2010 17:59:44 +0100 [thread overview]
Message-ID: <20100303165944.GN2490@gandalf.sssup.it> (raw)
In-Reply-To: <1267129704.22519.560.camel@laptop>
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Thu, Feb 25, 2010 09:28:24PM +0100
>
> On Tue, 2010-02-23 at 19:56 +0100, Fabio Checconi wrote:
> > +static inline void double_spin_lock(raw_spinlock_t *lock1,
> > + raw_spinlock_t *lock2)
> > + __acquires(lock1)
> > + __acquires(lock2)
> > +{
> > + if (lock1 < lock2) {
> > + raw_spin_lock(lock1);
> > + raw_spin_lock_nested(lock2, SINGLE_DEPTH_NESTING);
> > + } else {
> > + raw_spin_lock(lock2);
> > + raw_spin_lock_nested(lock1, SINGLE_DEPTH_NESTING);
> > + }
> > +}
> > +
> > +static inline void double_spin_unlock(raw_spinlock_t *lock1,
> > + raw_spinlock_t *lock2)
> > + __releases(lock1)
> > + __releases(lock2)
> > +{
> > + raw_spin_unlock(lock1);
> > + lock_set_subclass(&lock2->dep_map, 0, _RET_IP_);
> > + raw_spin_unlock(lock2);
> > +}
>
> If you release both there is no need to re-set the subclass.
Will fix, thanks.
next prev parent reply other threads:[~2010-03-03 16:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 18:56 [PATCH 0/3] sched: use EDF to throttle RT task groups v2 Fabio Checconi
2010-02-23 18:56 ` [PATCH 1/3] sched: use EDF to schedule groups Fabio Checconi
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 16:59 ` Fabio Checconi
2010-02-23 18:56 ` [PATCH 2/3] sched: enforce per-cpu utilization limits on runtime balancing Fabio Checconi
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 16:59 ` Fabio Checconi
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 17:00 ` Fabio Checconi
2010-03-23 20:32 ` Peter Zijlstra
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 16:59 ` Fabio Checconi [this message]
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 17:00 ` Fabio Checconi
2010-03-23 20:33 ` Peter Zijlstra
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 17:00 ` Fabio Checconi
2010-02-23 18:56 ` [PATCH 3/3] sched: make runtime balancing code more EDF-friendly Fabio Checconi
2010-02-25 20:28 ` Peter Zijlstra
2010-03-03 17:01 ` Fabio Checconi
2010-02-25 20:28 ` [PATCH 0/3] sched: use EDF to throttle RT task groups v2 Peter Zijlstra
2010-02-27 12:33 ` Peter Zijlstra
2010-03-03 17:01 ` Fabio Checconi
2010-03-23 20:30 ` Peter Zijlstra
2010-03-23 20:56 ` Dhaval Giani
2010-03-23 21:51 ` Tommaso Cucinotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303165944.GN2490@gandalf.sssup.it \
--to=fchecconi@gmail.com \
--cc=dhaval@retis.sssup.it \
--cc=faggioli@gandalf.sssup.it \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@evidence.eu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=t.cucinotta@sssup.it \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).