From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810Ab0DMTuc (ORCPT ); Tue, 13 Apr 2010 15:50:32 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:54189 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752374Ab0DMTua (ORCPT ); Tue, 13 Apr 2010 15:50:30 -0400 From: "Rafael J. Wysocki" To: Michal Hocko Subject: Re: commit 9630bdd9 changes behavior of the poweroff - bug? Date: Tue, 13 Apr 2010 22:53:37 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc3-rjw; KDE/4.3.5; x86_64; ; ) Cc: Tony Vroon , Jesse Barnes , Matthew Garrett , linux-kernel@vger.kernel.org, ACPI Devel Maling List , pm list References: <20100401133923.GA4104@tiehlicka.suse.cz> <201004130101.54117.rjw@sisk.pl> <20100413082756.GA5233@tiehlicka.suse.cz> In-Reply-To: <20100413082756.GA5233@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004132253.37432.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 13 April 2010, Michal Hocko wrote: > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > Please check if the patch below changes anything. > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > (I made sure to go through a full power down session before trying the > > > > patched kernel) > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > Can you please check if the patch below changes the behavior? > > Unfortunately, it didn't help either (I have tried on top of the fresh > rc4). That gets really weird. > > --- > > drivers/acpi/wakeup.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > =================================================================== > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > +++ linux-2.6/drivers/acpi/wakeup.c > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > struct acpi_device *dev = > > container_of(node, struct acpi_device, wakeup_list); > > + u8 action = ACPI_GPE_ENABLE; Can you try to change the above to ACPI_GPE_DISABLE and retest, please? > > if (!dev->wakeup.flags.valid) > > continue; > > > > if ((!dev->wakeup.state.enabled && !dev->wakeup.prepare_count) > > || sleep_state > (u32) dev->wakeup.sleep_state) > > - continue; > > + action = ACPI_GPE_DISABLE; > > > > - /* The wake-up power should have been enabled already. */ > > acpi_set_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number, > > - ACPI_GPE_ENABLE); > > + action); > > } > > } Rafael