From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323Ab0DNFlu (ORCPT ); Wed, 14 Apr 2010 01:41:50 -0400 Received: from bld-mail15.adl6.internode.on.net ([150.101.137.100]:40459 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752604Ab0DNFlt (ORCPT ); Wed, 14 Apr 2010 01:41:49 -0400 Date: Wed, 14 Apr 2010 15:41:44 +1000 From: Dave Chinner To: KAMEZAWA Hiroyuki Cc: Chris Mason , Mel Gorman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mm: disallow direct reclaim page writeback Message-ID: <20100414054144.GH2493@dastard> References: <1271117878-19274-1-git-send-email-david@fromorbit.com> <20100413095815.GU25756@csn.ul.ie> <20100413111902.GY2493@dastard> <20100413193428.GI25756@csn.ul.ie> <20100413202021.GZ13327@think> <20100414014041.GD2493@dastard> <20100414135945.2b0a1e0d.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100414135945.2b0a1e0d.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2010 at 01:59:45PM +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 14 Apr 2010 11:40:41 +1000 > Dave Chinner wrote: > > > 50) 3168 64 xfs_vm_writepage+0xab/0x160 [xfs] > > 51) 3104 384 shrink_page_list+0x65e/0x840 > > 52) 2720 528 shrink_zone+0x63f/0xe10 > > A bit OFF TOPIC. > > Could you share disassemble of shrink_zone() ? > > In my environ. > 00000000000115a0 : > 115a0: 55 push %rbp > 115a1: 48 89 e5 mov %rsp,%rbp > 115a4: 41 57 push %r15 > 115a6: 41 56 push %r14 > 115a8: 41 55 push %r13 > 115aa: 41 54 push %r12 > 115ac: 53 push %rbx > 115ad: 48 83 ec 78 sub $0x78,%rsp > 115b1: e8 00 00 00 00 callq 115b6 > 115b6: 48 89 75 80 mov %rsi,-0x80(%rbp) > > disassemble seems to show 0x78 bytes for stack. And no changes to %rsp > until retrun. I see the same. I didn't compile those kernels, though. IIUC, they were built through the Ubuntu build infrastructure, so there is something different in terms of compiler, compiler options or config to what we are both using. Most likely it is the compiler inlining, though Chris's patches to prevent that didn't seem to change the stack usage. I'm trying to get a stack trace from the kernel that has shrink_zone in it, but I haven't succeeded yet.... Cheers, Dave. -- Dave Chinner david@fromorbit.com