From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753761Ab0DNAXx (ORCPT ); Tue, 13 Apr 2010 20:23:53 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:52141 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597Ab0DNAXw (ORCPT ); Tue, 13 Apr 2010 20:23:52 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Wed, 14 Apr 2010 09:19:59 +0900 From: KAMEZAWA Hiroyuki To: Minchan Kim Cc: Andrew Morton , Mel Gorman , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter Subject: Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block Message-Id: <20100414091959.313c61b0.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <3108a367a27c55392904c3f046aa0b5420efe261.1271171877.git.minchan.kim@gmail.com> References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <3108a367a27c55392904c3f046aa0b5420efe261.1271171877.git.minchan.kim@gmail.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.2 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Apr 2010 00:25:01 +0900 Minchan Kim wrote: > if node_state is N_HIGH_MEMORY, node doesn't have -1. > It means node's validity check is unnecessary. > So we can use alloc_pages_exact_node instead of alloc_pages_node. > It could avoid comparison and branch as 6484eb3e2a81807722 tried. > > Cc: Christoph Lameter > Signed-off-by: Minchan Kim Reviewed-by: KAMEZAWA Hiroyuki