From: Andres Salomon <dilinger@queued.net>
To: linux-kernel@vger.kernel.org
Cc: linux-geode@bombadil.infradead.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Crypto: geode-aes: Fix some code style issues
Date: Thu, 15 Apr 2010 14:34:34 -0400 [thread overview]
Message-ID: <20100415143434.7b39e55f@debian> (raw)
In-Reply-To: <1271351879-22805-1-git-send-email-chihau@gmail.com>
On Thu, 15 Apr 2010 13:17:59 -0400
Chihau Chau <chihau@gmail.com> wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some code style issues like:
>
> - Use #include <linux/io.h> instead of <asm/io.h> and #include
> <linux/delay.h> instead of <asm/delay.h>
>
> - Use "foo *bar" instead of "foo * bar"
>
> - Add a space after the for or while sentence and before the open
> parenthesis '('
>
> - Don't use assignments in a if condition
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
Looks obviously correct to me.
Acked-by: Andres Salomon <dilinger@debian.org>
> ---
> drivers/crypto/geode-aes.c | 36 ++++++++++++++++++++----------------
> 1 files changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c
> index c7a5a43..09389dd 100644
> --- a/drivers/crypto/geode-aes.c
> +++ b/drivers/crypto/geode-aes.c
> @@ -15,14 +15,14 @@
> #include <crypto/algapi.h>
> #include <crypto/aes.h>
>
> -#include <asm/io.h>
> -#include <asm/delay.h>
> +#include <linux/io.h>
> +#include <linux/delay.h>
>
I don't see any delay functions being used anywhere; delay.h can
probably just be dropped.
next prev parent reply other threads:[~2010-04-15 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 17:17 [PATCH] Crypto: geode-aes: Fix some code style issues Chihau Chau
2010-04-15 18:34 ` Andres Salomon [this message]
2010-04-16 20:06 ` Sebastian Andrzej Siewior
2010-04-19 13:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415143434.7b39e55f@debian \
--to=dilinger@queued.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-geode@bombadil.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).