linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>, mingo@elte.hu
Cc: peterz@infradead.org, gorcunov@gmail.com, aris@redhat.com,
	linux-kernel@vger.kernel.org, randy.dunlap@oracle.com
Subject: Re: [PATCH v2] [watchdog] combine nmi_watchdog and softlockup
Date: Mon, 19 Apr 2010 17:21:35 -0400	[thread overview]
Message-ID: <20100419212135.GN15159@redhat.com> (raw)
In-Reply-To: <20100416014712.GC15570@nowhere>

On Fri, Apr 16, 2010 at 03:47:14AM +0200, Frederic Weisbecker wrote:
> On Thu, Apr 15, 2010 at 05:25:10PM -0400, Don Zickus wrote:
> > The new nmi_watchdog (which uses the perf event subsystem) is very
> > similar in structure to the softlockup detector.  Using Ingo's suggestion,
> > I combined the two functionalities into one file, kernel/watchdog.c.
> > 
> > Now both the nmi_watchdog (or hardlockup detector) and softlockup detector
> > sit on top of the perf event subsystem, which is run every 60 seconds or so
> > to see if there are any lockups.

Hello all,

After making a bunch of cleanups, I am stuck debating whether to continue
updating this patch on the stale branch perf/nmi on Ingo's tree or just
repost the whole patch again (which isn't much bigger just adds the
arch/x86/kernel/apic/hw_nmi.c piece).

Part of the new patch series includes removing kernel/nmi_watchdog.c,
which seemed kinda silly because it was only an intermediate file until
things got shifted to kernel/watchdog.c

Thoughts?

Cheers,
Don

  parent reply	other threads:[~2010-04-19 21:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15 21:25 [PATCH v2] [watchdog] combine nmi_watchdog and softlockup Don Zickus
2010-04-15 22:32 ` Randy Dunlap
2010-04-16 14:12   ` Don Zickus
2010-04-16  1:47 ` Frederic Weisbecker
2010-04-16 14:12   ` Don Zickus
2010-04-16 14:43     ` Frederic Weisbecker
2010-04-16 15:04       ` Don Zickus
2010-04-16 15:32         ` Frederic Weisbecker
2010-04-16 16:14           ` Don Zickus
2010-04-16 16:24             ` Frederic Weisbecker
2010-04-16 14:32   ` Cyrill Gorcunov
2010-04-16 14:46     ` Frederic Weisbecker
2010-04-16 14:53       ` Peter Zijlstra
2010-04-16 14:59         ` Frederic Weisbecker
2010-04-16 14:54       ` Cyrill Gorcunov
2010-04-16 14:46     ` Don Zickus
2010-04-19 21:21   ` Don Zickus [this message]
2010-04-19 21:35     ` Ingo Molnar
2010-04-19 21:51       ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419212135.GN15159@redhat.com \
    --to=dzickus@redhat.com \
    --cc=aris@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).