From: Andrew Morton <akpm@linux-foundation.org>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org,
gregkh@suse.de, alan@lxorguk.ukuu.org.uk, tytso@mit.edu,
iws@ovro.caltech.edu
Subject: Re: [PATCH 4/4] add example files to the kernel sample directory
Date: Sat, 15 May 2010 09:39:08 -0400 [thread overview]
Message-ID: <20100515093908.54290762.akpm@linux-foundation.org> (raw)
In-Reply-To: <1273930418.32082.12.camel@wall-e.seibold.net>
On Sat, 15 May 2010 15:33:38 +0200 Stefani Seibold <stefani@seibold.net> wrote:
> Hi,
>
> is the patch 0003-replace-the-old-non-generic-API.patch correct applied?
>
> This patch renames the files created by patch
>
> 0002-add-the-new-generic-kfifo-API.patch
>
> from
> kernel/kfifo-new.c into kernel/kfifo.c
> and
> include/linux/kfifo-new.h into include/linux/kfifo.h.
>
> Both destination files still exists, so git must overwrite them.
oh, doh, no. This stuff:
: diff --git a/include/linux/kfifo-new.h b/include/linux/kfifo.h
: similarity index 100%
: rename from include/linux/kfifo-new.h
: rename to include/linux/kfifo.h
: diff --git a/kernel/kfifo-new.c b/kernel/kfifo.c
: similarity index 100%
: rename from kernel/kfifo-new.c
: rename to kernel/kfifo.c
is git-specific and doesn't mean anything to patch(1). I'll fix it.
> This
> was done in request by Greg, not to break the kernel build at this point
> in the patch sequence.
Well, there can be no build problem here (joining two
non-build-breaking patches will yield a non-build-breaking patch!) but
if the add-new-api and replace-old-api patches were folded into a
single patch, the diff would be quite unreadable.
next prev parent reply other threads:[~2010-05-15 16:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:49 really generic, type save and type definable stefani
2010-05-12 8:49 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-05-12 8:49 ` [PATCH 2/4] add the new generic kfifo API stefani
2010-05-29 18:30 ` Ira W. Snyder
2010-05-29 18:48 ` Stefani Seibold
2010-05-29 19:09 ` Ira W. Snyder
2010-05-12 8:49 ` [PATCH 3/4] replace the old non generic API stefani
2010-05-12 8:49 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-05-14 20:46 ` Andrew Morton
2010-05-15 13:33 ` Stefani Seibold
2010-05-15 13:39 ` Andrew Morton [this message]
2010-05-28 7:43 ` really generic, type save and type definable Henrik Rydberg
2010-05-28 10:32 ` Stefani Seibold
2010-05-28 11:11 ` Henrik Rydberg
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 6:40 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-08-10 6:40 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-07-20 13:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-07-20 13:05 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-20 20:06 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-20 20:06 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-18 21:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 21:05 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-18 20:54 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 20:54 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-02-12 7:52 [PATCH 0/4] enhanced reimplemention of the kfifo API Stefani Seibold
2010-02-12 8:07 ` [PATCH 4/4] add example files to the kernel sample directory Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100515093908.54290762.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).