From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754459Ab0EYE6q (ORCPT ); Tue, 25 May 2010 00:58:46 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:45068 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310Ab0EYE6n (ORCPT ); Tue, 25 May 2010 00:58:43 -0400 Date: Mon, 24 May 2010 21:58:51 -0700 (PDT) Message-Id: <20100524.215851.207470612.davem@davemloft.net> To: sfr@canb.auug.org.au Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, herbert@gondor.hengli.com.au Subject: Re: linux-next: build failure after merge of the final tree From: David Miller In-Reply-To: <20100525141046.975afe1f.sfr@canb.auug.org.au> References: <20100525141046.975afe1f.sfr@canb.auug.org.au> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Rothwell Date: Tue, 25 May 2010 14:10:46 +1000 > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from net/socket.c:97: > include/net/cls_cgroup.h: In function 'task_cls_classid': > include/net/cls_cgroup.h:33: error: request for member 'classid' in something not a structure or union > In file included from net/core/sock.c:126: > include/net/cls_cgroup.h: In function 'task_cls_classid': > include/net/cls_cgroup.h:33: error: request for member 'classid' in something not a structure or union > In file included from net/sched/cls_cgroup.c:23: > include/net/cls_cgroup.h: In function 'task_cls_classid': > include/net/cls_cgroup.h:33: error: request for member 'classid' in something not a structure or union > > CONFIG_CGROUPS=y, CONFIG_NET_CLS_CGROUP=y > > Caused by commit f845172531fb7410c7fb7780b1a6e51ee6df7d52 ("cls_cgroup: > Store classid in struct sock") from the net-current tree. > > I have reverted that commit for today (and commit > 8286274284e15b11b0f531b6ceeef21fbe00a8dd "tun: Update classid on packet > injection" that depends on it). Yuck, and we already went through two iterations of this patch fixing exactly these kinds of build problems :-/ Herbert, can you take a look? Thanks!