From: Greg KH <greg@kroah.com>
To: "Henri Häkkinen" <henuxd@gmail.com>
Cc: gregkh@suse.de, ossama.othman@intel.com,
devel@driversdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: memrar: Moved memrar_allocator struct into memrar_allocator.c
Date: Tue, 22 Jun 2010 15:00:03 -0700 [thread overview]
Message-ID: <20100622220003.GA5121@kroah.com> (raw)
In-Reply-To: <1276516473-13685-1-git-send-email-henuxd@gmail.com>
On Mon, Jun 14, 2010 at 02:54:33PM +0300, Henri Häkkinen wrote:
> Forward declared memrar_allocator in memrar_allocator.h and moved it
> to memrar_allocator.c file. Implemented memrar_allocator_capacity() and
> memrar_allocator_largest_free_area().
Um, did you try building the code after this patch? It fails in bad
ways:
CC [M] drivers/staging/memrar/memrar_handler.o
drivers/staging/memrar/memrar_handler.c: In function ‘memrar_init_rar_resources’:
drivers/staging/memrar/memrar_handler.c:352:2: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c: In function ‘memrar_get_stat’:
drivers/staging/memrar/memrar_handler.c:548:25: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:550:23: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:551:35: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:552:25: error: dereferencing pointer to incomplete type
Please always build the patches you send out. I can't take
this one obviously :(
Care to fix it up?
thanks,
greg k-h
next prev parent reply other threads:[~2010-06-22 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 11:54 [PATCH] Staging: memrar: Moved memrar_allocator struct into memrar_allocator.c Henri Häkkinen
2010-06-22 22:00 ` Greg KH [this message]
2010-06-14 12:40 Henri Häkkinen
2010-06-23 17:51 ` Othman, Ossama
2010-06-24 9:35 ` Fwd: " Henri Häkkinen
2010-06-24 17:46 ` Othman, Ossama
2010-06-23 22:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622220003.GA5121@kroah.com \
--to=greg@kroah.com \
--cc=devel@driversdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=henuxd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ossama.othman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).