From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619Ab0F2Uiv (ORCPT ); Tue, 29 Jun 2010 16:38:51 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:60310 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359Ab0F2Uit (ORCPT ); Tue, 29 Jun 2010 16:38:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:reply-to:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=ZbzMN3gDTsBdnhLOq70NVV2KX7eLUYaEXVdQTxlIAFDwfmuN04hC03HYhRSjRgghHP EowC6kwL+vv6nFLHTfkS8EVudKqbjFDZhGnbRZcfnXSGTHaHf3KuddF6mVsn1dqUbhoD TNZ1VmnyHRnFbP1bhMdpZ67V2CkCuhn5hZi+4= From: Chris Clayton Reply-To: chris2553@googlemail.com To: Nick Piggin Subject: Re: [patch 02/52] fs: fix superblock iteration race Date: Tue, 29 Jun 2010 21:38:40 +0100 User-Agent: KMail/1.9.10 Cc: Linus Torvalds , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, John Stultz , Frank Mayhar , Al Viro References: <20100624030212.676457061@suse.de> <201006292104.33778.chris2553@googlemail.com> <20100629201409.GO28364@laptop> In-Reply-To: <20100629201409.GO28364@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201006292138.40293.chris2553@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 29 June 2010, Nick Piggin wrote: > On Tue, Jun 29, 2010 at 09:04:33PM +0100, Chris Clayton wrote: > > On Tuesday 29 June 2010, Linus Torvalds wrote: > > > On Tue, Jun 29, 2010 at 10:52 AM, Linus Torvalds > > > > > > wrote: > > > > Look for "2.6.35-rc3 oops trying to suspend" on lkml, for example. No > > > > guarantee that it's the same thing, but it's "iterate_supers()" > > > > getting an oops [..] > > > > > > Also, "Oops during closedown with 2.6.35-rc3-git3" is an > > > iterate_supers oops (in the jpg) and Chris says it's repeatable for > > > him. > > > > > > Chris - you could try testing current -git now that I've merged Nick's > > > patch. It's commit 57439f878af ("fs: fix superblock iteration race"), > > > and I just pushed it out (so it might take a few minutes to mirror out > > > to the public git trees, but it should be there shortly). > > > > Well, it was repeatable this morning, but despite 30+ shutdowns this > > evening, I haven't had a single oops. Perhaps I'm just not doing enough > > computing stuff between startup and shutdown to create the conditions > > under which I got the oopses this morning. Moreover, I've been using this > > kernel every day with, maybe two or three shutdowns a day, for two weeks > > or so now (since just after Linus went on vacation) with no oopses. (The > > kernel is -rc3 + John Fastabend's "net: fix deliver_no_wcard regression > > on loopback device" patch). > > > > I'll spend a couple of hours doing stuff and see if I can generate an > > oops. Trouble is, of course, that when I pull and build the latest and > > greatest, I won't know why I'm not getting oopses, assuming I don't. > > Don't worry too much if you can't reproduce. I'd say it is likely to be > this bug, and if so, it is going to depend significantly on timing and > ordering of mounts/umounts. Yes, that makes sense. I did quite a bit of copying files to and from USB storage devices this morning. I've got some more to do, so I'll see what that produces. -- The more I see, the more I know. The more I know, the less I understand. Changing Man - Paul Weller