From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827Ab0GAJxi (ORCPT ); Thu, 1 Jul 2010 05:53:38 -0400 Received: from gir.skynet.ie ([193.1.99.77]:45896 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927Ab0GAJxg (ORCPT ); Thu, 1 Jul 2010 05:53:36 -0400 Date: Thu, 1 Jul 2010 10:53:18 +0100 From: Mel Gorman To: Minchan Kim Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH 01/14] vmscan: Fix mapping use after free Message-ID: <20100701095318.GE31741@csn.ul.ie> References: <1277811288-5195-1-git-send-email-mel@csn.ul.ie> <1277811288-5195-2-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2010 at 11:27:05PM +0900, Minchan Kim wrote: > On Tue, Jun 29, 2010 at 8:34 PM, Mel Gorman wrote: > > From: Nick Piggin > > > > Use lock_page_nosync in handle_write_error as after writepage we have no > > reference to the mapping when taking the page lock. > > > > Signed-off-by: Nick Piggin > > Signed-off-by: Mel Gorman > > Trivial. > Please modify description of the function if you have a next turn. > "run sleeping lock_page()" -> "run sleeping lock_page_nosync" > Fixed, thanks. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab