Re: [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle

From: Pavel Machek <pavel@ucw.cz>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
	rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle
Date: Sun, 18 Jul 2010 14:36:43 +0200	[thread overview]
Message-ID: <20100718123643.GF30716@elf.ucw.cz> (raw)
In-Reply-To: <4C1F83EB.8060703@gmail.com>

On Mon 2010-06-21 17:23:23, Jiri Slaby wrote:
> On 06/10/2010 03:55 PM, Pavel Machek wrote:
> > It would be good if you carried ack-s from previous rounds, so that I
> > don't have to review good patches again...
> 
> Hi, previously ACKed patches were merged already. These were much
> rewritten and their original versions were rather NACKed. Otherwise I
> transfer ACKs indeed.

Thanks!

> >> +/**
> >> + * hib_io_handle_alloc - allocate io handle with priv_size for private data
> >> + *
> >> + * @priv_size: the sie to allocate behind hibernate_io_handle for private use
> >> + */
> >> +static inline struct hibernate_io_handle *hib_io_handle_alloc(size_t priv_size)
> >> +{
> >> +	struct hibernate_io_handle *ret;
> >> +	ret = kzalloc(sizeof(*ret) + priv_size, GFP_KERNEL);
> >> +	if (ret)
> >> +		ret->priv = ret + 1;
> > 
> > Uhuh, why this? Aha, grabbing the pointer to priv_size-sized area at
> > the end of regular struct?
> 
> Yes, exactly, any more transparent way to do it?

Normally, I believe void data[]; is added at the end of structure, and
then something like ret->priv = &ret->data; is done...?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html