From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758737Ab0HLHqa (ORCPT ); Thu, 12 Aug 2010 03:46:30 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:49415 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475Ab0HLHq3 (ORCPT ); Thu, 12 Aug 2010 03:46:29 -0400 Date: Thu, 12 Aug 2010 17:46:21 +1000 From: Stephen Rothwell To: Steve French Cc: linux-cifs@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Wang Lei , Bryan Schumaker , David Howells Subject: Re: linux-next: build failure after merge of the cifs tree Message-Id: <20100812174621.b1dbc20f.sfr@canb.auug.org.au> In-Reply-To: References: <20100812131741.f3a800d7.sfr@canb.auug.org.au> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Thu__12_Aug_2010_17_46_21_+1000_yjLM=8lGx_xPYx0p" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Signature=_Thu__12_Aug_2010_17_46_21_+1000_yjLM=8lGx_xPYx0p Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Steve, On Wed, 11 Aug 2010 23:04:36 -0500 Steve French wrote: > > Are you sure that this is a valid config file? CONFIG_KEYS should be > set if CONFIG_DNS_RESOLVER is set? It is a ppc64_defconfig. It has: # CONFIG_KEYS is not set CONFIG_DNS_RESOLVER=3Dy CONFIG_NFS_USE_KERNEL_DNS just selects CONFIG_DNS_RESOLVER but there is no dependency on CONFIG_KEYS (select does not care about the dependencies of the selected config option). > key.h looks like it is included in all arch in this path >=20 > net/dns_resolver/dns_key.c includes > include/keys/dns_resolver-type.h which includes > include/linux/key-type.h which includes > include/linux/key.h >=20 > the line 258 "key_instantiate_and_link" error could occur if > "CONFIG_KEYS" is not set in .config Which t isn't. > net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS" > so ... CONFIG_KEYS should be set .... See above. You need CONFIG_NFS_USE_KERNEL_DNS to also depend on CONFIG_KEYS ... --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Thu__12_Aug_2010_17_46_21_+1000_yjLM=8lGx_xPYx0p Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBAgAGBQJMY6bNAAoJEDMEi1NhKgbsTqsH/0RUu72CT13xLIua6gpSidpS sC2do6Jb4ISLMVMEDlQbOUniz2Q+GhXylnxoFIHfWPYJywO5K6vS4Y3HPfi4kREs SIhNu687LNUGzdCZA47Aqn1BpSjqO6fWWjYGombtN5SG5UcYdsQaGMqypr+vVSJn N6Is9sq6/ZjIRdFXk+m6JNnbQGRPBgn/7y2k8BWnbtW520HmKDRqakdqHg71sRLm fuQ4L1N8OUUfnFPqdBKRPA+0H9v75Q4zPhKa5GpgR/Yzdi5vD/2U+OlIXaFuxMgG qztqdq7Hl40fnVTim0fHalgfKzUx4J2d/zUMSNPLKM6z9Ht6/S+ZR5Ylu3VpyBQ= =xbsW -----END PGP SIGNATURE----- --Signature=_Thu__12_Aug_2010_17_46_21_+1000_yjLM=8lGx_xPYx0p--