Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/usb/gadget/nokia.c:244: error: unknown field 'bind' specified in initializer drivers/usb/gadget/nokia.c:244: warning: initialization makes integer from pointer without a cast drivers/usb/gadget/nokia.c:244: error: initializer element is not computable at load time drivers/usb/gadget/nokia.c:244: error: (near initialization for 'nokia_driver.needs_serial') drivers/usb/gadget/nokia.c: In function 'nokia_init': drivers/usb/gadget/nokia.c:250: error: implicit declaration of function 'usb_composite_register' Caused by commit cc604fa9db859b7d6899de807d6bd8df80fc0a1a ("usb gadget: don't save bind callback in struct usb_configuration"). The 'bind' and 'usb_composite_register' references above were added before 2.6.34-rc1 but missed in this patch. Please make every attempt to (at least) build every file that gets modified when testing a patch. (and grep is your friend) I have used the usb tree from next-20100901 for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/