From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] i915: Add native backlight control
Date: Thu, 9 Sep 2010 18:14:09 +0100 [thread overview]
Message-ID: <20100909171409.GA25746@srcf.ucam.org> (raw)
In-Reply-To: <8u3s94$gfdh5f@orsmga002.jf.intel.com>
On Thu, Sep 09, 2010 at 06:09:40PM +0100, Chris Wilson wrote:
> On Wed, 8 Sep 2010 12:32:18 -0400, Matthew Garrett <mjg@redhat.com> wrote:
> > Not all systems expose a firmware or platform mechanism for changing the
> > backlight intensity on i915, so add native driver support.
>
> This will conflict with a similar patch I have in drm-intel-next to unify
> the various bits of code that were attempting to modify the BLC PWM, each
> in their own unique fashion.
>
> I'll respin this native interface on top of that. Do you want to add a
> native RAW interface all in one go, or to base it on the current
> backlight_device and then to add the RAW property with this patch set?
I don't think providing a native interface in i915 is beneficial without
providing the type information - userspace just doesn't have any way to
identify the correct device otherwise.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-09-09 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 16:32 [PATCH] Backlight: Add backlight type Matthew Garrett
2010-09-08 16:32 ` [PATCH] i915: Add native backlight control Matthew Garrett
2010-09-09 17:09 ` [Intel-gfx] " Chris Wilson
2010-09-09 17:14 ` Matthew Garrett [this message]
2010-09-10 13:38 ` [PATCH] drm/i915: Expose a native backlight device Chris Wilson
2010-09-10 13:47 ` Matthew Garrett
2010-09-08 16:32 ` [PATCH] radeon: Expose backlight class device for legacy LVDS encoder Matthew Garrett
2010-09-08 16:58 ` Alex Deucher
2010-09-08 17:03 ` Matthew Garrett
2010-09-08 17:04 ` Alex Deucher
2010-09-13 7:54 ` Michel Dänzer
2010-09-15 11:38 ` Michel Dänzer
2010-09-09 16:59 ` [PATCH] Backlight: Add backlight type Mike Frysinger
2010-11-15 15:48 ` [Intel-gfx] " Matthew Garrett
2010-11-15 16:44 ` Jesse Barnes
2011-03-24 6:53 ` Mike Frysinger
2011-03-24 7:13 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909171409.GA25746@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).